fix: Remove expected-failure tag and related test.fail calls from contract tests

Author: Sushant092003

specs/openapi/execute-contract-tests/execute-contract-tests-excluded.spec.ts

@@ -34,10 +34,8 @@ async function runAndVerifyCounts(
 test.describe("API Contract testing with test exclusion and inclusion", () => {
   test(
     "Exclude specific tests and verify excluded tests are not executed",
-    { tag: ["@test", "@testExclusion", "@eyes", "@expected-failure"] },
+    { tag: ["@test", "@testExclusion", "@eyes"] },
     async ({ page, eyes }, testInfo) => {
-      test.fail(true, "Needs fixing by the devs");
-
       const contractPage = new ApiContractPage(
         page,
         testInfo,

specs/openapi/execute-contract-tests/execute-contract-tests-filter.spec.ts

@@ -27,9 +27,8 @@ test.describe("API Contract Testing - Filtering", () => {
 
   test(
     "Verify filtering by header",
-    { tag: ["@test", "@filterTest", "@eyes", "@expected-failure"] },
+    { tag: ["@test", "@filterTest", "@eyes"] },
     async () => {
-      test.fail(true, "Needs fixing by the devs");
       await test.step("Enter service URL and run contract tests", async () => {
         await contractPage.enterServiceUrl(ORDER_BFF_SERVICE_URL);
         await contractPage.setGenerativeMode(false);

specs/openapi/execute-contract-tests/execute-contract-tests-generative.spec.ts

@@ -12,10 +12,9 @@ import {
 test.describe(
   "Generative Test Suite - Include/Exclude Combinations",
   {
-    tag: ["@test", "@generativeTests", "@eyes", "@expected-failure"],
+    tag: ["@test", "@generativeTests", "@eyes"],
   },
   () => {
-    test.fail(true, "Needs fixing by the devs");
     let contractPage: ApiContractPage;
 
     test.beforeEach(async ({ page, eyes }, testInfo) => {

specs/openapi/execute-contract-tests/execute-contract-tests-main.spec.ts

@@ -31,9 +31,8 @@ test.describe("API Contract Testing", () => {
 
   test(
     "Run contract tests for openapi spec product_search_bff_v5.yaml with default settings",
-    { tag: ["@test", "@runContractTests", "@eyes", "@expected-failure"] },
+    { tag: ["@test", "@runContractTests", "@eyes"] },
     async () => {
-      test.fail(true, "Needs fixing by the devs");
       await test.step("Enter service URL and run contract tests", async () => {
         await contractPage.enterServiceUrl(ORDER_BFF_SERVICE_URL);
         await contractPage.clickRunContractTests();