Skip to content

Commit 7029569

Browse files
authored
Merge pull request kubernetes-sigs#574 from mboersma/dev-docs-tweaks
docs: fix a link and some typos in developer doc
2 parents 330d655 + 15ef62f commit 7029569

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

docs/development.md

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -42,22 +42,23 @@
4242
1. Install [go][go]
4343
- Get the latest patch version for go v1.13.
4444
2. Install [jq][jq]
45-
- `brew install jq` on MacOS.
45+
- `brew install jq` on macOS.
4646
- `chocolatey install jq` on Windows.
47-
- `sudo apt-get install jq` on Linux.
47+
- `sudo apt install jq` on Ubuntu Linux.
4848
3. Install [gettext][gettext] package
49-
- `brew install gettext && brew link --force gettext` on MacOS.
50-
- [install instructions](gettextwindows) on Windows.
49+
- `brew install gettext && brew link --force gettext` on macOS.
50+
- [install instructions][gettextwindows] on Windows.
51+
- `sudo apt install gettext` on Ubuntu Linux.
5152
4. Install [KIND][kind]
5253
- `GO111MODULE="on" go get sigs.k8s.io/[email protected]`.
5354
5. Install [Kustomize][kustomize]
54-
- `brew install kustomize` on MacOs.
55+
- `brew install kustomize` on macOS.
5556
- `choco install kustomize` on Windows.
5657
- [install instructions][kustomizelinux] on Linux
5758
6. Configure Python 2.7+ with [pyenv][pyenv] if your default is Python 3.x.
5859
7. Install make.
5960
8. Install [timeout][timeout]
60-
- `brew install coreutils` on MacOS.
61+
- `brew install coreutils` on macOS.
6162

6263
### Get the source
6364

@@ -96,14 +97,16 @@ To pin a new dependency:
9697
- Run `go get <repository>@<version>`.
9798
- (Optional) Add a `replace` statement in `go.mod`.
9899

99-
A few Makefile and scripts are offered to work with go modules:
100+
Makefile targets and scripts are offered to work with go modules:
100101

101-
- `hack/ensure-go.sh` file checks that the Go version and environment variables are properly set.
102+
- `make verify-modules` checks whether go module files are out of date.
103+
- `make modules` runs `go mod tidy` to ensure proper vendoring.
104+
- `hack/ensure-go.sh` checks that the Go version and environment variables are properly set.
102105

103106
### Setting up the environment
104107

105108
Your environment must have the Azure credentials as outlined in the [getting
106-
started prerequisites section](./getting-started.md#Prerequisites)
109+
started prerequisites](./getting-started.md#Prerequisites) section.
107110

108111
### Using Tilt
109112

@@ -150,20 +153,20 @@ make kind-reset
150153

151154
If you want to develop in both CAPI and CAPZ at the same time, then this is the path for you.
152155

153-
To use [Tilt](https://tilt.dev/) for a simplified development workflow, follow the [instructions](https://cluster-api.sigs.k8s.io/developer/tilt.html) in the cluster-api repo. The instructions will walk you through cloning the Cluster API (capi) repository and configuring Tilt to use `kind` to deploy the cluster api management components.
156+
To use [Tilt](https://tilt.dev/) for a simplified development workflow, follow the [instructions](https://cluster-api.sigs.k8s.io/developer/tilt.html) in the cluster-api repo. The instructions will walk you through cloning the Cluster API (CAPI) repository and configuring Tilt to use `kind` to deploy the cluster api management components.
154157

155-
> you may wish to checkout out the correct version of capi to match the [version used in capz](go.mod)
158+
> you may wish to checkout out the correct version of CAPI to match the [version used in CAPZ](go.mod)
156159
157160
Note that `tilt up` will be run from the `cluster-api repository` directory and the `tilt-settings.json` file will point back to the `cluster-api-provider-azure` repository directory. Any changes you make to the source code in `cluster-api` or `cluster-api-provider-azure` repositories will automatically redeployed to the `kind` cluster.
158161

159-
After you have cloned both repositories your folder structure should look like:
162+
After you have cloned both repositories, your folder structure should look like:
160163

161164
```tree
162165
|-- src/cluster-api-provider-azure
163166
|-- src/cluster-api (run `tilt up` here)
164167
```
165168

166-
After configuring the environment variables, you can run the following to generate you `tilt-settings.json` file:
169+
After configuring the environment variables, run the following to generate your `tilt-settings.json` file:
167170

168171
```shell
169172
cat <<EOF > tilt-settings.json
@@ -274,8 +277,7 @@ export AZURE_SSH_PUBLIC_KEY=$(cat "${SSH_KEY_FILE}.pub" | base64 | tr -d '\r\n')
274277
Ensure dev environment has been reset:
275278

276279
```bash
277-
make clean
278-
make kind-reset
280+
make clean kind-reset
279281
```
280282

281283
Create the cluster:
@@ -294,7 +296,7 @@ time kubectl get po -o wide --all-namespaces -w # Watch pod creation until azure
294296
kubectl logs -n capz-system azure-provider-controller-manager-0 manager -f # Follow the controller logs
295297
```
296298

297-
An error such as the following in the manager could point to a miss match between a current capi with old capz version:
299+
An error such as the following in the manager could point to a mismatch between a current CAPI and an old CAPZ version:
298300

299301
```
300302
E0320 23:33:33.288073 1 controller.go:258] controller-runtime/controller "msg"="Reconciler error" "error"="failed to create AzureMachine VM: failed to create nic capz-cluster-control-plane-7z8ng-nic for machine capz-cluster-control-plane-7z8ng: unable to determine NAT rule for control plane network interface: strconv.Atoi: parsing \"capz-cluster-control-plane-7z8ng\": invalid syntax" "controller"="azuremachine" "request"={"Namespace":"default","Name":"capz-cluster-control-plane-7z8ng"}
@@ -323,7 +325,7 @@ Kubernetes cluster, nor do they have external dependencies.
323325

324326
#### Mocks
325327

326-
Mocks for the services tests are generated using [GoMock][gomock]
328+
Mocks for the services tests are generated using [GoMock][gomock].
327329

328330
To generate the mocks you can run
329331

0 commit comments

Comments
 (0)