fix: bypass proxy for local server pubkey fetch in build script#2085
fix: bypass proxy for local server pubkey fetch in build script#2085
Conversation
The `cargo build` command inside `implants/lib/pb` uses `reqwest` to fetch a public key from `http://127.0.0.1:8000/status`. In environments using proxies like Codespaces/devcontainers, `reqwest`'s default behavior failed to connect correctly. Replaced `reqwest::blocking::get` with a `reqwest::blocking::Client::builder().no_proxy().build().unwrap().get()` initialization in `build.rs` to explicitly bypass any proxy configuration and directly connect to localhost. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
Fixes an issue where
cargo buildinimplants/lib/pbfails to fetch the public key from the local Tavern server due to proxy misconfigurations in development environments.Changes made:
reqwest::blocking::Client::builder().no_proxy().build().unwrap().get(&status_url).send()instead ofreqwest::blocking::get(&status_url).{}) format for the error log with Debug ({:?}) to get more verbose error traces.PR created automatically by Jules for task 11601507693399375597 started by @hulto