fix: update registry guardrail to parse full path including hive#2108
fix: update registry guardrail to parse full path including hive#2108
Conversation
Updated the `Registry` guardrail struct and `check()` logic to accept a single `path` value, matching the syntax used by Eldritch's registry read function. The guardrail now parses the root hive (e.g., HKLM, HKCU) and subkey from the given path string, instead of attempting to blindly check both local machine and current user hives. The parsing ignores case for maximum robustness and aligns with typical Windows behavior. Additionally, renamed the field `subkey` to `path` with a Serde alias to preserve backwards compatibility, and updated the inline tests to validate full paths. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
This PR updates the registry guardrail to use a full path string instead of separating the subkey and checking both
HKEY_LOCAL_MACHINEandHKEY_CURRENT_USERblindly.It imports path-splitting logic to determine the correct root hive directly from the path prefix (e.g.,
HKLM\SOFTWARE\...), ensuring the behavior aligns with how Eldritch scripts natively reference registry keys.Also includes a backwards-compatibility alias for the Serde configuration to prevent breaking previously built implants. Tests have been updated and run locally.
PR created automatically by Jules for task 3908199613466224958 started by @hulto