rbf: fix issues with bump_frr_through_decreasing_change

- break from loop if target is reached
- recompute delta if there is no next iteration.

Author: ecdsa

electrum/wallet.py

@@ -1948,6 +1948,8 @@ def _bump_fee_through_decreasing_change(
         for o in s:
             target_fee = int(math.ceil(tx.estimated_size() * new_fee_rate))
             delta = target_fee - tx.get_fee()
+            if delta <= 0:
+                break
             i = outputs.index(o)
             if o.value - delta >= self.dust_threshold():
                 new_output_value = o.value - delta
@@ -1959,6 +1961,11 @@ def _bump_fee_through_decreasing_change(
                 del outputs[i]
                 # note: we mutated the outputs of tx, which will affect
                 #       tx.estimated_size() in the next iteration
+        else:
+            # recompute delta if there was no next iteration
+            target_fee = int(math.ceil(tx.estimated_size() * new_fee_rate))
+            delta = target_fee - tx.get_fee()
+
         if delta > 0:
             raise CannotBumpFee(_('Could not find suitable outputs'))