Skip to content

Wallet password unification on Android: enforce irreversibility #9075

@SomberNight

Description

@SomberNight

On Android, in the past, each wallet could have a separate wallet password.
Then #6805 introduced the wallet password unification.
With that:

  • every time a wallet is opened, or a wallet password is changed, we check if the password is or can be unified
  • it is considered a legacy state to have multiple wallets that have different passwords
  • if the password is unified, when the user creates a new wallet, we automatically use it for the new wallet
    • otherwise, the wizard lets the user type a new password for the new wallet

Note that before any wallet is opened, currently we don't know if the password is unified.
The kivy gui did not allow creation of new wallets until an existing wallet was opened (#6805 (comment)). The qml gui however allows this atm. This lets the user reverse password unification by creating a new wallet with a different password.

Maybe we could revert to the kivy behaviour and disable the create wallet button (or show popup when it is clicked) until a wallet is opened.


Some problematic/impossible use cases/scenarios:

  • user who forgot their wallet password will not be able to create a new wallet (only recourse is to reinstall the application)
  • multiple people wanting to use the same phone and each have their own wallet with different passwords

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions