Skip to content

Commit b6d1d86

Browse files
committed
session: 'server.version' must tolerate and ignore extra unknown args
to leave room for future extensions
1 parent e819516 commit b6d1d86

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/electrumx/server/session.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1528,11 +1528,20 @@ async def ping(self):
15281528
self.bump_cost(0.1)
15291529
return None
15301530

1531-
async def server_version(self, client_name='', protocol_version=None):
1531+
async def server_version(
1532+
self,
1533+
client_name='',
1534+
protocol_version=None,
1535+
*extra_args,
1536+
**extra_kwargs,
1537+
):
15321538
'''Returns the server version as a string.
15331539
15341540
client_name: a string identifying the client
15351541
protocol_version: the protocol version spoken by the client
1542+
1543+
note: extraneous unknown args for 'server.version' MUST be tolerated
1544+
and ignored by the server, to allow for future extensions.
15361545
'''
15371546
self.bump_cost(0.5)
15381547
if self.sv_seen:

0 commit comments

Comments
 (0)