publisher: drop space key check on connection

This extension performs a series of little checks when starting a first
connection to ensure users are indeed talking to a Confluence instance.
This is to help rule our misconfigured sites or dealing with proxy
issues. One check performed used the configured key value and sanity
checked it against what Confluence reported the key was as well. While
functional for some time, Confluence Cloud now appears to replace the
key value from a reported space key to a new system key. This causes
the checks to fail, preventing publishing. To help alleviate the issue,
we will not longer perform a key check.

Signed-off-by: James Knight <[email protected]>

Author: jdknight

sphinxcontrib/confluencebuilder/publisher.py

@@ -170,14 +170,6 @@ def connect(self):
             msg = 'server did not provide an expected response; missing entries'
             raise ConfluenceBadServerUrlError(server_url, msg)
 
-        detected_key = rsp['key']
-        if detected_key != self.space_key:
-            msg = (
-                'server did not provide an expected response; '
-                f'bad space key match; {detected_key} != {self.space_key}'
-            )
-            raise ConfluenceBadServerUrlError(server_url, msg)
-
         # track required space information
         self.space_display_name = rsp['name']
         self.space_id = rsp['id']