Skip to content

Commit 5e0c709

Browse files
authored
Merge pull request #762 from sphinx-contrib/write-change-comment-for-new-pages
publisher: ensure new pages include a configured version comment
2 parents 2754702 + a3f7162 commit 5e0c709

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

doc/configuration.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1557,6 +1557,14 @@ Advanced publishing configuration
15571557
.. confval:: confluence_version_comment
15581558

15591559
.. versionadded:: 1.8
1560+
.. versionchanged:: 2.1
1561+
1562+
Support comments for first/new pages on Confluence Cloud.
1563+
1564+
.. note::
1565+
1566+
Confluence Server/DC does not support setting a version comment for
1567+
the first/new page revision.
15601568

15611569
A string value to be added as a comment to Confluence's version history.
15621570

sphinxcontrib/confluencebuilder/publisher.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -931,6 +931,10 @@ def _build_page(self, page_name, data):
931931
'space': {
932932
'key': self.space_key,
933933
},
934+
'version': {
935+
'number': 1,
936+
'message': self.config.confluence_version_comment,
937+
},
934938
}
935939

936940
if self.editor:
@@ -972,10 +976,7 @@ def _update_page(self, page, page_name, data, parent_id=None):
972976

973977
update_page = self._build_page(page_name, data)
974978
update_page['id'] = page['id']
975-
update_page['version'] = {
976-
'number': last_version + 1,
977-
'message': self.config.confluence_version_comment,
978-
}
979+
update_page['version']['number'] = last_version + 1
979980

980981
labels = list(data['labels'])
981982
if self.append_labels:

0 commit comments

Comments
 (0)