Skip to content

Conversation

@jdknight
Copy link
Member

@jdknight jdknight commented Mar 4, 2023

For sphinx.ext.linkcode extension, prospect changes [1] will provide support for other Sphinx extensions to take advantage of linkcode-generated references. Updating this extension to hint that it
will support sphinx.ext.linkcode. This should help ensure a future release the Confluence Builder extension will automatically be ready to utilize the Sphinx-managed extension (if Sphinx does update to include linkcode support for custom builders).

If Sphinx changes the way of integrating with linkcode or opts to not support such an extension, the introduced line in this commit can be modified or dropped at a later time.

[1]: sphinx-doc/sphinx#10585

jdknight added 2 commits March 4, 2023 17:11
For `sphinx.ext.linkcode` references, the original handling of these
nodes would right-align the links for the "[source]" references. Using
a div-float for this alignment is not supported with Confluence's new
editor style. For an initial rendering support for this preliminary
linkcode support, ensure the link is place appropriately on the same
link as a autodoc line description, and that the content is properly
spaced.

Signed-off-by: James Knight <[email protected]>
For `sphinx.ext.linkcode` extension, prospect changes [1] will provide
support for other Sphinx extensions to take advantage of
linkcode-generated references. Updating this extension to hint that it
will support `sphinx.ext.linkcode`. This should help ensure a future
release the Confluence Builder extension will automatically be ready to
utilize the Sphinx-managed extension (if Sphinx does update to include
linkcode support for custom builders).

If Sphinx changes the way of integrating with linkcode or opts to not
support such an extension, the introduced line in this commit can be
modified or dropped at a later time.

[1]: sphinx-doc/sphinx#10585

Signed-off-by: James Knight <[email protected]>
@jdknight jdknight merged commit 5a0c18e into main Mar 4, 2023
@jdknight jdknight deleted the ext-linkcode-support branch March 4, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants