From 63a39fb9665eaf85852d92edec3ade4668a510af Mon Sep 17 00:00:00 2001
From: Jean Abou Samra <jean@abou-samra.fr>
Date: Wed, 23 Feb 2022 19:26:53 +0100
Subject: [PATCH] Add check for missing space after directive ::

For example:

.. versionadded::0.1

This is taken as a comment, thus no warning from docutils/Sphinx.

This doesn't yield any false positives in CPython.

Closes #7
---
 sphinxlint.py                                    | 6 ++++++
 tests/fixtures/xfail/directive-missing-space.rst | 4 ++++
 tests/fixtures/xpass/directive-no-arguments.rst  | 3 +++
 3 files changed, 13 insertions(+)
 create mode 100644 tests/fixtures/xfail/directive-missing-space.rst
 create mode 100644 tests/fixtures/xpass/directive-no-arguments.rst

diff --git a/sphinxlint.py b/sphinxlint.py
index 21a976b22..d796faf36 100755
--- a/sphinxlint.py
+++ b/sphinxlint.py
@@ -119,6 +119,10 @@
 # .. versionchanged:: 3.6
 three_dot_directive_re = re.compile(r"\.\.\. %s::" % all_directives)
 
+# Find directive missing space after double colon, like:
+# .. versionchanged::3.6
+missing_space_directive_re = re.compile(r"(?<!\.)\.\. %s::[^\s]" % simplename)
+
 # Find role used with double backticks instead of simple backticks like:
 # :const:``None``
 # instead of:
@@ -217,6 +221,8 @@ def check_suspicious_constructs(file, lines):
             yield lno, "comment seems to be intended as a directive"
         if three_dot_directive_re.search(line):
             yield lno, "directive should start with two dots, not three."
+        if missing_space_directive_re.search(line):
+            yield lno, "missing space after :: in directive"
         if double_backtick_role.search(line):
             yield lno, "role use a single backtick, double backtick found."
         if role_glued_with_word.search(line):
diff --git a/tests/fixtures/xfail/directive-missing-space.rst b/tests/fixtures/xfail/directive-missing-space.rst
new file mode 100644
index 000000000..7f73b4228
--- /dev/null
+++ b/tests/fixtures/xfail/directive-missing-space.rst
@@ -0,0 +1,4 @@
+Missing space after ``::`` here:
+
+.. versionchanged::0.1
+   Foo bar baz.
diff --git a/tests/fixtures/xpass/directive-no-arguments.rst b/tests/fixtures/xpass/directive-no-arguments.rst
new file mode 100644
index 000000000..51a296762
--- /dev/null
+++ b/tests/fixtures/xpass/directive-no-arguments.rst
@@ -0,0 +1,3 @@
+Some directives can be invoked without arguments or content.
+
+.. contents::