add support for missing toctree theme_options #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navigation.html's toctree was missing support for maxdepth and titles_only.
|
This is an interesting feature, can it be included / labelled as "to-be-reviewed" ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigation.html's toctree was missing support for maxdepth and titles_only. I don't think the end-user should have to override navigation.html just to change these settings.
I wasn't quite sure how to properly enable an integer option, as it still ends up in the document as a string (even though the boolean appears to route through fine), so I convert it to an int on the toctree call.
This closes #89