cleanup

Author: picnixz

sphinx/util/typing.py

@@ -182,7 +182,10 @@ def restify(cls: type | None, mode: str = 'fully-qualified-except-typing') -> st
             return f':py:class:`{modprefix}{cls.__name__}`'
         elif ismock(cls):
             return f':py:class:`{modprefix}{cls.__module__}.{cls.__name__}`'
-        elif is_invalid_builtin_class(cls):  # this never raises TypeError
+        elif is_invalid_builtin_class(cls):
+            # The above predicate never raises TypeError but should not be
+            # evaluated before determining whether *cls* is a mocked object
+            # or not; instead of two try-except blocks, we keep it here.
             return f':py:class:`{modprefix}{_INVALID_BUILTIN_CLASSES[cls]}`'
         elif inspect.isNewType(cls):
             if sys.version_info[:2] >= (3, 10):