Refactor is_suppressed_warning to use set lookups (#12539)

Author: AA-Turner

sphinx/util/logging.py

@@ -16,7 +16,7 @@
 from sphinx.util.osutil import abspath
 
 if TYPE_CHECKING:
-    from collections.abc import Iterator
+    from collections.abc import Iterator, Sequence, Set
 
     from docutils.nodes import Node
 
@@ -407,23 +407,18 @@ def filter(self, record: logging.LogRecord) -> bool:
         return record.levelno < logging.WARNING
 
 
-def is_suppressed_warning(type: str, subtype: str, suppress_warnings: list[str]) -> bool:
+def is_suppressed_warning(
+    warning_type: str, sub_type: str, suppress_warnings: Set[str] | Sequence[str],
+) -> bool:
     """Check whether the warning is suppressed or not."""
-    if type is None:
+    if warning_type is None or len(suppress_warnings) == 0:
         return False
-
-    subtarget: str | None
-
-    for warning_type in suppress_warnings:
-        if '.' in warning_type:
-            target, subtarget = warning_type.split('.', 1)
-        else:
-            target, subtarget = warning_type, None
-
-        if target == type and subtarget in (None, subtype, "*"):
-            return True
-
-    return False
+    suppressed_warnings = frozenset(suppress_warnings)
+    if warning_type in suppressed_warnings:
+        return True
+    if f'{warning_type}.*' in suppressed_warnings:
+        return True
+    return f'{warning_type}.{sub_type}' in suppressed_warnings
 
 
 class WarningSuppressor(logging.Filter):
@@ -441,7 +436,7 @@ def filter(self, record: logging.LogRecord) -> bool:
             suppress_warnings = self.app.config.suppress_warnings
         except AttributeError:
             # config is not initialized yet (ex. in conf.py)
-            suppress_warnings = []
+            suppress_warnings = ()
 
         if is_suppressed_warning(type, subtype, suppress_warnings):
             return False