Bump Ruff to 0.8.1

Author: AA-Turner

pyproject.toml

@@ -82,7 +82,7 @@ docs = [
 ]
 lint = [
     "flake8>=6.0",
-    "ruff==0.8.0",
+    "ruff==0.8.1",
     "mypy==1.13.0",
     "sphinx-lint>=0.9",
     "types-colorama==0.4.15.20240311",

sphinx/builders/latex/transforms.py

@@ -151,7 +151,7 @@ def renumber_footnotes(self) -> None:
                     break
 
             # assign new footnote number
-            old_label = cast(nodes.label, footnote[0])
+            old_label = cast('nodes.label', footnote[0])
             old_label.replace_self(nodes.label('', str(num)))
             if old_label in footnote['names']:
                 footnote['names'].remove(old_label.astext())

sphinx/builders/linkcheck.py

@@ -251,7 +251,7 @@ def _add_uri(self, uri: str, node: nodes.Element) -> None:
         :param uri: URI to add
         :param node: A node class where the URI was found
         """
-        builder = cast(CheckExternalLinksBuilder, self.app.builder)
+        builder = cast('CheckExternalLinksBuilder', self.app.builder)
         hyperlinks = builder.hyperlinks
         docname = self.env.docname
 

sphinx/directives/__init__.py

@@ -81,7 +81,7 @@ def get_field_type_map(self) -> dict[str, tuple[Field, bool]]:
                     self._doc_field_type_map[name] = (field, False)
 
                 if field.is_typed:
-                    typed_field = cast(TypedField, field)
+                    typed_field = cast('TypedField', field)
                     for name in typed_field.typenames:
                         self._doc_field_type_map[name] = (field, True)
 
@@ -346,7 +346,7 @@ def run(self) -> list[Node]:
             )
             messages += [error]
 
-        return cast(list[nodes.Node], messages)
+        return cast('list[nodes.Node]', messages)
 
 
 class DefaultDomain(SphinxDirective):

sphinx/directives/other.py

@@ -376,7 +376,7 @@ def run(self) -> list[Node]:
             # Use these depths to determine where the nested sections should
             # be placed in the doctree.
             n_sects_to_raise = current_depth - nested_depth + 1
-            parent = cast(nodes.Element, self.state.parent)
+            parent = cast('nodes.Element', self.state.parent)
             for _i in range(n_sects_to_raise):
                 if parent.parent:
                     parent = parent.parent

sphinx/directives/patches.py

@@ -38,15 +38,15 @@ def run(self) -> list[Node]:
             return result
 
         assert len(result) == 1
-        figure_node = cast(nodes.figure, result[0])
+        figure_node = cast('nodes.figure', result[0])
         if name:
             # set ``name`` to figure_node if given
             self.options['name'] = name
             self.add_name(figure_node)
 
         # copy lineno from image node
         if figure_node.line is None and len(figure_node) == 2:
-            caption = cast(nodes.caption, figure_node[1])
+            caption = cast('nodes.caption', figure_node[1])
             figure_node.line = caption.line
 
         return [figure_node]
@@ -163,7 +163,7 @@ def run(self) -> list[Node]:
         return ret
 
     def add_target(self, ret: list[Node]) -> None:
-        node = cast(nodes.math_block, ret[0])
+        node = cast('nodes.math_block', ret[0])
 
         # assign label automatically if math_number_all enabled
         if node['label'] == '' or (self.config.math_number_all and not node['label']):  # NoQA: PLC1901

sphinx/domains/c/_ast.py

@@ -1793,14 +1793,14 @@ def clone(self) -> ASTDeclaration:
 
     @property
     def name(self) -> ASTNestedName:
-        decl = cast(DeclarationType, self.declaration)
+        decl = cast('DeclarationType', self.declaration)
         return decl.name
 
     @property
     def function_params(self) -> list[ASTFunctionParameter] | None:
         if self.objectType != 'function':
             return None
-        decl = cast(ASTType, self.declaration)
+        decl = cast('ASTType', self.declaration)
         return decl.function_params
 
     def get_id(self, version: int, prefixed: bool = True) -> str:
@@ -1851,7 +1851,7 @@ def describe_signature(self, signode: TextElement, mode: str,
             mainDeclNode += addnodes.desc_sig_keyword('enumerator', 'enumerator')
             mainDeclNode += addnodes.desc_sig_space()
         elif self.objectType == 'type':
-            decl = cast(ASTType, self.declaration)
+            decl = cast('ASTType', self.declaration)
             prefix = decl.get_type_declaration_prefix()
             mainDeclNode += addnodes.desc_sig_keyword(prefix, prefix)
             mainDeclNode += addnodes.desc_sig_space()

sphinx/domains/citation.py

@@ -117,7 +117,7 @@ def apply(self, **kwargs: Any) -> None:
             domain.note_citation(node)
 
             # mark citation labels as not smartquoted
-            label = cast(nodes.label, node[0])
+            label = cast('nodes.label', node[0])
             label['support_smartquotes'] = False
 
 

sphinx/domains/python/__init__.py

@@ -542,10 +542,10 @@ def filter_meta_fields(app: Sphinx, domain: str, objtype: str, content: Element)
 
     for node in content:
         if isinstance(node, nodes.field_list):
-            fields = cast(list[nodes.field], node)
+            fields = cast('list[nodes.field]', node)
             # removing list items while iterating the list needs reversed()
             for field in reversed(fields):
-                field_name = cast(nodes.field_body, field[0]).astext().strip()
+                field_name = cast('nodes.field_body', field[0]).astext().strip()
                 if field_name == 'meta' or field_name.startswith('meta '):
                     node.remove(field)
 

sphinx/domains/std/__init__.py

@@ -7,7 +7,6 @@
 from typing import TYPE_CHECKING, Any, ClassVar, Final, cast
 
 from docutils import nodes
-from docutils.nodes import Element, Node, system_message
 from docutils.parsers.rst import Directive, directives
 from docutils.statemachine import StringList
 
@@ -25,6 +24,8 @@
 if TYPE_CHECKING:
     from collections.abc import Callable, Iterable, Iterator, Set
 
+    from docutils.nodes import Element, Node, system_message
+
     from sphinx.application import Sphinx
     from sphinx.builders import Builder
     from sphinx.environment import BuildEnvironment
@@ -813,7 +814,7 @@ def process_doc(
                                location=node)
             self.anonlabels[name] = docname, labelid
             if node.tagname == 'section':
-                title = cast(nodes.title, node[0])
+                title = cast('nodes.title', node[0])
                 sectname = clean_astext(title)
             elif node.tagname == 'rubric':
                 sectname = clean_astext(node)
@@ -824,9 +825,9 @@ def process_doc(
             else:
                 if (isinstance(node, nodes.definition_list | nodes.field_list) and
                         node.children):
-                    node = cast(nodes.Element, node.children[0])
+                    node = cast('nodes.Element', node.children[0])
                 if isinstance(node, nodes.field | nodes.definition_list_item):
-                    node = cast(nodes.Element, node.children[0])
+                    node = cast('nodes.Element', node.children[0])
                 if isinstance(node, nodes.term | nodes.field_name):
                     sectname = clean_astext(node)
                 else:
@@ -1117,7 +1118,7 @@ def is_enumerable_node(self, node: Node) -> bool:
     def get_numfig_title(self, node: Node) -> str | None:
         """Get the title of enumerable nodes to refer them using its title"""
         if self.is_enumerable_node(node):
-            elem = cast(Element, node)
+            elem = cast('Element', node)
             _, title_getter = self.enumerable_nodes.get(elem.__class__, (None, None))
             if title_getter:
                 return title_getter(elem)