HTML Search: fixup: include partially-matched document titles in search results.

sphinx/themes/basic/static/searchtools.js

@@ -478,12 +478,12 @@ const Search = {
       if (word.length > 2) {
         const escapedWord = _escapeRegExp(word);
         Object.keys(terms).forEach((term) => {
-          if (term.match(escapedWord) && !terms[word])
+          if (term.match(escapedWord) && terms[word] === undefined)
             arr.push({ files: terms[term], score: Scorer.partialTerm });
         });
         Object.keys(titleTerms).forEach((term) => {
-          if (term.match(escapedWord) && !titleTerms[word])
-            arr.push({ files: titleTerms[word], score: Scorer.partialTitle });
+          if (term.match(escapedWord) && titleTerms[word] === undefined)
+            arr.push({ files: titleTerms[term], score: Scorer.partialTitle });
         });
       }
 

tests/js/searchtools.js

@@ -21,7 +21,32 @@ describe('Basic html theme search', function() {
         "<no title>",
         "",
         null,
-        2,
+        5,
+        "index.rst"
+      ]];
+      expect(Search.performTermsSearch(searchterms, excluded, terms, titleterms)).toEqual(hits);
+    });
+
+    it('should partially-match "sphinx" when in title index', function() {
+      index = {
+        docnames:["index"],
+        filenames:["index.rst"],
+        terms:{'useful': 0, 'utilities': 0},
+        titles:["sphinx_utils module"],
+        titleterms:{'sphinx_utils': 0}
+      }
+      Search.setIndex(index);
+      searchterms = ['sphinx'];
+      excluded = [];
+      terms = index.terms;
+      titleterms = index.titleterms;
+
+      hits = [[
+        "index",
+        "sphinx_utils module",
+        "",
+        null,
+        7,
         "index.rst"
       ]];
       expect(Search.performTermsSearch(searchterms, excluded, terms, titleterms)).toEqual(hits);