-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[search] Refactor: make the search code more testable. #12107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jayaddison
wants to merge
23
commits into
sphinx-doc:master
from
jayaddison:refactor/extract-search-result-gathering
Closed
[search] Refactor: make the search code more testable. #12107
jayaddison
wants to merge
23
commits into
sphinx-doc:master
from
jayaddison:refactor/extract-search-result-gathering
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chindex.js test fixtures
…able in test cases
… refactor/extract-search-result-gathering
…directory containing test case files
…9-prep/extract-js-search-index-fixtures Conflicts: sphinx/themes/basic/static/searchtools.js
… refactor/extract-search-result-gathering
…xtract-search-result-gathering Conflicts: utils/generate_js_fixtures.py
Contributor
Author
|
Awaits possible merge of #12102; moving into draft status until then. |
Contributor
Author
It seems I've unintentionally merged most of this into #12102. I'll close this and merge the remainder too, so that there's only one PR to review. It could make sense to separate some of it out again, but to begin with a single PR should be less confusing I expect. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
Detail
Search._parseQueryto transform a query into search terms.Search._performSearchto run a query and return results using search term arguments.Relates