Skip to content

Commit 033e9f7

Browse files
committed
🐛 FIx: images labelling for myst images
fixes regression from previous commit
1 parent c0b4c56 commit 033e9f7

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

docs/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ Sub-figure with adaptive layouts
276276

277277
---
278278

279-
:::{subfigure} 2
279+
:::{subfigure} AB
280280
:subcaptions: above
281281
:class-grid: outline
282282

src/sphinx_subfigure/main.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ def run(self) -> list[nodes.Element]:
5959

6060
number_of_images = 0
6161
has_caption = False
62-
for idx, child in enumerate(figure_node):
62+
for idx, child in enumerate(list(figure_node)):
6363
if isinstance(child, nodes.image):
64+
child["subfigure_area"] = string.ascii_uppercase[number_of_images]
6465
number_of_images += 1
65-
child["subfigure_area"] = string.ascii_uppercase[idx]
6666
elif (
6767
isinstance(child, nodes.paragraph)
6868
and child.children
@@ -72,9 +72,9 @@ def run(self) -> list[nodes.Element]:
7272
for sub in child:
7373
if not isinstance(sub, nodes.image):
7474
continue
75-
number_of_images += 1
7675
images.append(sub)
77-
sub["subfigure_area"] = string.ascii_uppercase[idx]
76+
sub["subfigure_area"] = string.ascii_uppercase[number_of_images]
77+
number_of_images += 1
7878
child.replace_self(images)
7979
elif isinstance(child, nodes.paragraph):
8080
if has_caption:
@@ -87,6 +87,7 @@ def run(self) -> list[nodes.Element]:
8787
f"item {idx + 1} is neither (line {child.line})"
8888
)
8989

90+
print(number_of_images)
9091
layout_string = self.arguments[0] if self.arguments else 1
9192
figure_node["layout"] = {}
9293
figure_node["layout"]["default"] = self.generate_layout(

0 commit comments

Comments
 (0)