Skip to content

Commit 9398dfe

Browse files
committed
fix based on suggestion from CodeRabbit
1 parent 058b436 commit 9398dfe

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

CustomApps/lyrics-plus/ProviderMusixmatch.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -245,14 +245,16 @@ const ProviderMusixmatch = (() => {
245245
const cached = localStorage.getItem("lyrics-plus:musixmatch-languages");
246246
if (cached) {
247247
const tempMap = JSON.parse(cached);
248-
// Check if any value starts with a lowercase letter (indicating old cache)
249-
const hasLowercase = Object.values(tempMap).some((name) => name && name[0] === name[0].toLowerCase() && name[0] !== name[0].toUpperCase());
250-
if (!hasLowercase) {
248+
// Check cache version
249+
if (tempMap.__version === 1) {
250+
delete tempMap.__version;
251251
languageMap = tempMap;
252252
return languageMap;
253253
}
254254
}
255-
} catch {}
255+
} catch (e) {
256+
console.warn("Failed to parse cached languages", e);
257+
}
256258

257259
const baseURL = "https://apic-desktop.musixmatch.com/ws/1.1/languages.get?app_id=web-desktop-app-v1.0&get_romanized_info=1&";
258260

@@ -278,7 +280,7 @@ const ProviderMusixmatch = (() => {
278280
if (lang.language_iso_code_3) languageMap[lang.language_iso_code_3] = name;
279281
}
280282
});
281-
localStorage.setItem("lyrics-plus:musixmatch-languages", JSON.stringify(languageMap));
283+
localStorage.setItem("lyrics-plus:musixmatch-languages", JSON.stringify({ ...languageMap, __version: 1 }));
282284
return languageMap;
283285
}
284286
} catch (e) {

0 commit comments

Comments
 (0)