.golangci.yml

version: "2"
run:
  concurrency: 8
  allow-parallel-runners: true
output:
  formats:
    text:
      path: stdout
linters:
  enable:
    - asasalint
    - asciicheck
    - bidichk
    - bodyclose
    - decorder
    - dogsled
    - durationcheck
    - errchkjson
    - exptostd
    - ginkgolinter
    - gocheckcompilerdirectives
    - gochecksumtype
    - gocritic
    - goheader
    - goprintffuncname
    - gosmopolitan
    - grouper
    - iface
    - importas
    - intrange
    - loggercheck
    - makezero
    - mirror
    - nilnesserr
    - nosprintfhostport
    - reassign
    - recvcheck
    - revive
    - rowserrcheck
    - sqlclosecheck
    - testableexamples
    - testifylint
    - unconvert
    - usetesting
    - wastedassign
    - zerologlint
    - canonicalheader
    - containedctx
    - contextcheck
    - copyloopvar
    - cyclop
    - dupl
    - dupword
    - errcheck
    - errname
    - errorlint
    - exhaustive
    - forcetypeassert
    - funlen
    - gochecknoglobals
    - gochecknoinits
    - gocognit
    - goconst
    - godot
    - godox
    - gomoddirectives
    - gomodguard
    - gosec
    - inamedparam
    - interfacebloat
    - ireturn
    - lll
    - misspell
    - mnd
    - musttag
    - nakedret
    - nilerr
    - nilnil
    - nlreturn
    - noctx
    - nolintlint
    - nonamedreturns
    - paralleltest
    - predeclared
    - promlinter
    - protogetter
    - spancheck
    - tagalign
    - tagliatelle
    - thelper
    - tparallel
    - unparam
    - usestdlibvars
    - varnamelen
    - whitespace
  disable:
    - depguard
    - err113
    - sloglint
    - wsl
    - exhaustruct
    - forbidigo
    - testpackage
    - wrapcheck
    # CLI-specific exclusions - these are too pedantic for command-line tools
    - gochecknoglobals  # Cobra commands require package-level vars
    - gochecknoinits    # Cobra flag setup uses init()
    - nlreturn          # Excessive whitespace requirements
    - varnamelen        # Short names like 'c' for cobra.Command are idiomatic
    - mnd               # Magic numbers in CLI flags are fine
    - paralleltest      # Not all tests benefit from parallelization
    - tagliatelle       # snake_case in YAML config is conventional
    - funlen            # Command handlers are naturally longer
    - lll               # Long lines in help text are acceptable
    - godot             # Comment punctuation is pedantic
    - ireturn           # Returning interfaces is fine for formatters
    - gomoddirectives   # go.mod directives are intentional
    - protogetter       # Direct proto field access is fine for CLI output
    - exhaustive        # Not all switch statements need all cases
    # Additional pragmatic exclusions for runtime code
    - errchkjson        # JSON marshal errors in tests are fine
    - inamedparam       # Named parameters in interfaces are pedantic
    - nilnil            # Returning nil,nil is acceptable in some cases
    - nolintlint        # Nolint directives are intentional
    - predeclared       # Some predeclared names are fine in specific contexts
    - whitespace        # Trailing whitespace is cosmetic
    - unparam           # Unused params may be needed for interface compliance
    - revive            # Often overlaps with other linters
    - noctx             # Context not always needed for exec.Command
  settings:
    cyclop:
      max-complexity: 20
    dupl:
      threshold: 250
    gocognit:
      min-complexity: 120
    revive:
      rules:
        - name: exported
          arguments:
            - disableStutteringCheck
    sloglint:
      context: all
    staticcheck:
      checks:
        - all
    usetesting:
      # The context checks are disabled by default since usetesting v0.5.0, CI is still using an older version,
      # so disabling them explicitly for now. These checks have caused some churn for us in CI as well, not all
      # occurrences of them are valid.
      context-background: false
      context-todo: false
  exclusions:
    generated: lax
    rules:
      - linters:
          - ineffassign
        path: conversion\.go
      - linters:
          - ineffassign
        text: ineffectual assignment to ctx
      - linters:
          - staticcheck
        text: this value of `ctx` is never used
      - linters:
          - wastedassign
        text: assigned to ctx, but never used afterwards
      - linters:
          - forbidigo
        path: _test.go$
        text: should not be used because managedFields was removed
      # Errcheck exclusions for cleanup operations
      - linters:
          - errcheck
        text: "Error return value of.*Close"
      - linters:
          - errcheck
        text: "Error return value of.*Remove"
      - linters:
          - errcheck
        text: "Error return value of.*Wait"
      - linters:
          - errcheck
        text: "Error return value of.*Set"
      - linters:
          - errcheck
        text: "Error return value of.*ReleaseNetworkResources"
      - linters:
          - errcheck
        text: "Error return value of.*io.Copy"
      - linters:
          - errcheck
        path: _test\.go$
      - linters:
          - gosec
        text: G115  # Integer overflow conversion is acceptable for CLI flags
      - linters:
          - gosec
        text: G104  # Unhandled errors covered by errcheck exclusions
      - linters:
          - gosec
        text: G301  # Directory permissions 0755 are standard for system directories
      - linters:
          - gosec
        text: G306  # File permissions 0644 are standard for config files
      - linters:
          - gosec
        text: G204  # Subprocess with variable is intentional (shim launch)
      - linters:
          - gosec
        text: G304  # File inclusion via variable is intentional for CLI
      # Service structs legitimately store context for service lifetime
      - linters:
          - containedctx
        path: internal/(guest/vminit/task/service|host/network/network)\.go
      # Test style preferences
      - linters:
          - testifylint
        text: "for error assertions use require"
      - linters:
          - thelper
        path: _test\.go$
      # Style preferences that are too pedantic
      - linters:
          - godox
        text: "TODO"
      - linters:
          - nonamedreturns
        text: "named return"
      - linters:
          - inamedparam
        text: "parameter name"
      - linters:
          - unparam
        text: "is unused"
      # Package comments (can be added incrementally)
      - linters:
          - staticcheck
        text: "ST1000"
      # Nil checks are fine
      - linters:
          - staticcheck
        text: "S1009"
      # ALL_CAPS for syscall constants is acceptable
      - linters:
          - staticcheck
        text: "ST1003.*ALL_CAPS"
      # Type inference suggestions are pedantic
      - linters:
          - staticcheck
        text: "QF1011"
      # Force type assert in internal code is acceptable
      - linters:
          - forcetypeassert
        path: internal/
      # Errorlint %v in tests is acceptable
      - linters:
          - errorlint
        path: _test\.go$
      # Named returns can be useful for readability
      - linters:
          - nakedret
        text: "naked return"
    paths:
      - third_party$
      - builtin$
      - examples$
issues:
  max-issues-per-linter: 0
  max-same-issues: 0
formatters:
  enable:
    - gofmt
    - goimports
  exclusions:
    generated: lax
    paths:
      - third_party$
      - builtin$