Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Oct 30, 2024

  • Adds a pre-delete helm hook to check if any SpinApp or SpinAppExecutor custom resources exist in the cluster; if so, fail the hook and thus the deletion attempt
    • Note: the top-level helm delete command will time out and the error will only be seen if the user procures the logs from the 'pre-delete' job pod(s). In the context of the Marketplace, this might not make its way to an 'extension failed to uninstall' error; unsure here.
  • Adds a post-delete helm hook to remove all SpinKube CRDs (at time of writing, these include the Cert-Manager dependency CRDs as well as the SpinApp(Executor) CRDs).
    • Note: The hook also deletes the release namespace as a final step, since helm does not do this.
  • Updates the helm smoke test GH workflow with assertions for the above logic

Ref #26

@vdice vdice requested a review from Mossaka October 30, 2024 00:41
@vdice vdice force-pushed the feat/marketplace-uninstall branch 2 times, most recently from 5abf3df to 789a87c Compare October 30, 2024 18:02
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment on lines +95 to +97
kubectl get pods -A
kubectl get crd -A
kubectl get ns -A
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add kubectl describe as well?

@vdice vdice force-pushed the feat/marketplace-uninstall branch from 789a87c to ab4699a Compare November 5, 2024 18:40
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vdice
Copy link
Collaborator Author

vdice commented Nov 5, 2024

Oops, CI happened to hit a cpa verify error. I created #31 to fix. We can merge 31 first and I can rebase this afterwards.

@Mossaka
Copy link
Member

Mossaka commented Nov 5, 2024

Just merged #31

@vdice vdice force-pushed the feat/marketplace-uninstall branch from ab4699a to 1178c01 Compare November 5, 2024 19:01
@vdice vdice merged commit a4b8f92 into spinframework:main Nov 5, 2024
3 checks passed
@vdice vdice deleted the feat/marketplace-uninstall branch November 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants