-
Notifications
You must be signed in to change notification settings - Fork 2
feat(marketplace): pre-delete resource check and post-delete complete uninstall #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5abf3df to
789a87c
Compare
Mossaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
| kubectl get pods -A | ||
| kubectl get crd -A | ||
| kubectl get ns -A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add kubectl describe as well?
789a87c to
ab4699a
Compare
Mossaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Oops, CI happened to hit a |
|
Just merged #31 |
Signed-off-by: Vaughn Dice <[email protected]>
…d delete namespace Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
ab4699a to
1178c01
Compare
helm deletecommand will time out and the error will only be seen if the user procures the logs from the 'pre-delete' job pod(s). In the context of the Marketplace, this might not make its way to an 'extension failed to uninstall' error; unsure here.Ref #26