Skip to content

Commit 0a67bbb

Browse files
Update inline commenting
Signed-off-by: Kate Goldenring <[email protected]>
1 parent 7cacbc5 commit 0a67bbb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

conformance-tests/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ impl SpinShim {
110110
image: &str,
111111
env: &mut TestEnvironment<R>,
112112
) -> anyhow::Result<()> {
113-
// TODO: consider enabling configuring a port
114113
let mut cmd = Command::new(spin_binary_path);
115114
cmd.args(["registry", "push", "-k"]).arg(image);
116115
env.run_in(&mut cmd)
@@ -119,7 +118,6 @@ impl SpinShim {
119118
}
120119

121120
pub fn image_pull(ctr_binary_path: &Path, image: &str) -> anyhow::Result<()> {
122-
// TODO: consider enabling configuring a port
123121
Command::new(ctr_binary_path)
124122
.args(["image", "pull"])
125123
.arg(image)
@@ -136,13 +134,15 @@ impl SpinShim {
136134
image: &str,
137135
ctr_run_id: &str,
138136
) -> anyhow::Result<Self> {
137+
// TODO: consider enabling configuring a port
139138
let port = 80;
140139
let mut ctr_cmd = std::process::Command::new(ctr_binary_path);
141140
let child = ctr_cmd
142141
.arg("run")
143142
.args(["--rm", "--net-host", "--runtime", "io.containerd.spin.v2"])
144143
.arg(image)
145144
.arg(ctr_run_id)
145+
// The container runtime expects at least one argument to the container
146146
.arg("bogus-arg")
147147
.stdout(Stdio::piped())
148148
.stderr(Stdio::piped());

0 commit comments

Comments
 (0)