Skip to content

Commit 6306be5

Browse files
committed
engine: add more context to the variables
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
1 parent 0bd6c95 commit 6306be5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

containerd-shim-spin/src/engine.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,13 @@ impl Engine for SpinEngine {
6464
stdio.redirect()?;
6565

6666
// Set the container environment variables which will be collected by Spin's
67-
// [environment variable provider].
67+
// [environment variable provider]. We use these variables to configure both the Spin runtime
68+
// and the Spin application per the [SKIP 003] proposal.
69+
//
6870
// TODO: This is a temporary solution to allow Spin to collect the container environment variables.
6971
// We should later look into other variable providers to collect container variables.
7072
//
73+
// [SKIP 003]: https://github.com/spinkube/skips/tree/main/proposals/003-shim-runtime-options
7174
// [environment variable provider]: https://github.com/fermyon/spin/blob/v3.0.0/crates/variables/src/env.rs
7275
ctx.envs().iter().for_each(|v| {
7376
let (key, value) = v.split_once('=').unwrap_or((v.as_str(), ""));

0 commit comments

Comments
 (0)