Skip to content

Commit 80f8d0c

Browse files
committed
node-installer: allow overriding image name via env var
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
1 parent 0da970a commit 80f8d0c

File tree

4 files changed

+24
-12
lines changed

4 files changed

+24
-12
lines changed

node-installer/integration-test-k3s.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#!/bin/bash
22
set -euo pipefail
33

4+
# Default image name that can be overridden via environment variables
5+
: ${IMAGE_NAME:=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev}
6+
47
echo "Installing K3s..."
58
curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC="--disable=traefik --write-kubeconfig-mode=644" sh -
69

@@ -17,7 +20,7 @@ kubectl create namespace kwasm || true
1720
kubectl apply -f ../deployments/workloads/runtime.yaml
1821

1922
echo "=== Step 3: Build and deploy the KWasm node installer ==="
20-
if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:dev >/dev/null 2>&1; then
23+
if ! docker image inspect $IMAGE_NAME >/dev/null 2>&1; then
2124
echo "Building node installer image..."
2225
PLATFORM=$(uname -m)
2326
if [ "$PLATFORM" = "x86_64" ]; then
@@ -31,11 +34,11 @@ if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:d
3134
exit 1
3235
fi
3336

34-
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev make build-dev-installer-image
37+
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=$IMAGE_NAME make build-dev-installer-image
3538
fi
3639

3740
echo "Loading node installer image into K3s..."
38-
docker save ghcr.io/spinkube/containerd-shim-spin/node-installer:dev > node-installer.tar
41+
docker save $IMAGE_NAME > node-installer.tar
3942
sudo k3s ctr images import node-installer.tar
4043
rm node-installer.tar
4144

node-installer/integration-test-kind.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#!/bin/bash
22
set -euo pipefail
33

4+
# Default image name that can be overridden via environment variables
5+
: ${IMAGE_NAME:=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev}
6+
47
echo "=== Step 1: Create a kind cluster ==="
58
if kind get clusters | grep -q "spin-test"; then
69
echo "Deleting existing cluster..."
@@ -16,7 +19,7 @@ kubectl --context=kind-spin-test create namespace kwasm || true
1619
kubectl --context=kind-spin-test apply -f ../deployments/workloads/runtime.yaml
1720

1821
echo "=== Step 3: Build and deploy the KWasm node installer ==="
19-
if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:v0.18.0 >/dev/null 2>&1; then
22+
if ! docker image inspect $IMAGE_NAME >/dev/null 2>&1; then
2023
echo "Building node installer image..."
2124
PLATFORM=$(uname -m)
2225
if [ "$PLATFORM" = "x86_64" ]; then
@@ -30,11 +33,11 @@ if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:v
3033
exit 1
3134
fi
3235

33-
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev make build-dev-installer-image
36+
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=$IMAGE_NAME make build-dev-installer-image
3437
fi
3538

3639
echo "Loading node installer image into kind..."
37-
kind load docker-image ghcr.io/spinkube/containerd-shim-spin/node-installer:dev --name spin-test
40+
kind load docker-image $IMAGE_NAME --name spin-test
3841

3942
echo "Applying KWasm node installer job..."
4043
kubectl --context=kind-spin-test apply -f ./kwasm-job.yml

node-installer/integration-test-microk8s.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#!/bin/bash
22
set -euo pipefail
33

4+
# Default image name that can be overridden via environment variables
5+
: ${IMAGE_NAME:=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev}
6+
47
echo "=== Step 1: Setup MicroK8s ==="
58
if ! command -v microk8s >/dev/null 2>&1; then
69
echo "MicroK8s is not installed. Please install it first."
@@ -25,7 +28,7 @@ kubectl create namespace kwasm || true
2528
kubectl apply -f ../deployments/workloads/runtime.yaml
2629

2730
echo "=== Step 3: Build and deploy the KWasm node installer ==="
28-
if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:dev >/dev/null 2>&1; then
31+
if ! docker image inspect $IMAGE_NAME >/dev/null 2>&1; then
2932
echo "Building node installer image..."
3033
PLATFORM=$(uname -m)
3134
if [ "$PLATFORM" = "x86_64" ]; then
@@ -39,11 +42,11 @@ if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:d
3942
exit 1
4043
fi
4144

42-
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev make build-dev-installer-image
45+
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=$IMAGE_NAME make build-dev-installer-image
4346
fi
4447

4548
echo "Loading node installer image into MicroK8s..."
46-
docker save ghcr.io/spinkube/containerd-shim-spin/node-installer:dev > node-installer.tar
49+
docker save $IMAGE_NAME > node-installer.tar
4750
sudo microk8s ctr image import node-installer.tar
4851
rm node-installer.tar
4952

node-installer/integration-test-minikube.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#!/bin/bash
22
set -euo pipefail
33

4+
# Default image name that can be overridden via environment variables
5+
: ${IMAGE_NAME:=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev}
6+
47
echo "=== Step 1: Create a MiniKube cluster ==="
58
minikube start -p minikube --driver=docker --container-runtime=containerd
69

@@ -9,7 +12,7 @@ kubectl create namespace kwasm || true
912
kubectl apply -f ../deployments/workloads/runtime.yaml
1013

1114
echo "=== Step 3: Build and deploy the KWasm node installer ==="
12-
if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:dev >/dev/null 2>&1; then
15+
if ! docker image inspect $IMAGE_NAME >/dev/null 2>&1; then
1316
echo "Building node installer image..."
1417
PLATFORM=$(uname -m)
1518
if [ "$PLATFORM" = "x86_64" ]; then
@@ -23,11 +26,11 @@ if ! docker image inspect ghcr.io/spinkube/containerd-shim-spin/node-installer:d
2326
exit 1
2427
fi
2528

26-
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=ghcr.io/spinkube/containerd-shim-spin/node-installer:dev make build-dev-installer-image
29+
PLATFORM=$PLATFORM ARCH=$ARCH IMAGE_NAME=$IMAGE_NAME make build-dev-installer-image
2730
fi
2831

2932
echo "Loading node installer image into MiniKube..."
30-
minikube image load ghcr.io/spinkube/containerd-shim-spin/node-installer:dev -p minikube
33+
minikube image load $IMAGE_NAME -p minikube
3134

3235
NODE_NAME=$(kubectl get nodes --context=minikube -o jsonpath='{.items[0].metadata.name}')
3336
cp kwasm-job.yml minikube-kwasm-job.yml

0 commit comments

Comments
 (0)