chore: bump minimal rust version to 1.81 #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
requested review from
devigned,
jsturtevant,
kate-goldenring and
radu-matei
as code owners
Collaborator
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
Should the Spin Dockerfile rust version also be bumped: https://github.com/spinkube/containerd-shim-spin/blob/1a93553a2abaa7921a480fd53ad71f2f1d31c1f2/images/spin/Dockerfile#L1
kate-goldenring
approved these changes
Jan 10, 2025
Collaborator
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
@Mossaka I think it would be good to get this in. E2E tests failing we can take on in another pr
Collaborator
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
mossaka/bump-rust-1.81
branch
from
59c2cc7 to
eaae688
Compare
Member
Author
|
rebased |
Member
Author
|
I am gonna merge this PR since it adds the CHANGELOG change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.