feat(otel): Enable opentelemetry for the Spin shim #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
requested review from
devigned,
jsturtevant,
kate-goldenring and
radu-matei
as code owners
Collaborator
|
@Mossaka what is the flow for configuring an OTEL ingester in your example? I am assuming that otel config needs to be passed somewhere else besides the container spec |
Member
Author
It's passed down by containerd. https://github.com/containerd/runwasi/blob/main/docs/opentelemetry.md |
Member
Author
|
I am going to merge this in now and let me know if you have further comments on this PR. @calebschoepp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the opentelemetry feature from the containerd-shim-wasm which provides otel for the shim process. Before
containerd-shim-wasm v0.9.0, the container process would inherit the otel runtime from the shim process, and thus causing a conflict with the spin telemetry runtime. Now, the container process was initialized (a.k.a zygote process) at the very begining when the shim process is in a clean state, and so it is free to initialize it's own otel runtime.This PR builds on top of #271
FYI @calebschoepp
Example