Dockerfile: Refactor Dockerfiles to separate WASM target addition and build steps #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build steps This is to optimize the build process and reduce the number of layers in the Docker images. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
requested review from
devigned,
jsturtevant,
kate-goldenring and
radu-matei
as code owners
jprendes
approved these changes
Mar 7, 2025
jprendes
left a comment
jprendes
left a comment
There was a problem hiding this comment.
LGTM
This will save some time and bandwidth during dev work :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to optimize the build process and reduce the number of layers in the Docker images.
FYI @jprendes