Skip to content

chore(rust-toolchain): bump rust to 1.88.0, address fmt/clippy errs #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

chore(rust-toolchain): bump rust to 1.88.0, address fmt/clippy errs #367

merged 2 commits into from
Oct 27, 2025

Conversation

@vdice
Copy link
Contributor

@vdice vdice commented Oct 27, 2025 •
edited
Loading

  • Bumps rust to 1.88.0: 4d1290a
  • Addresses cargo fmt/clippy errs: 1b660f7

Motivated by the following error encountered when attempting to build:

error: failed to compile `cross v0.2.5 (https://github.com/cross-rs/cross?rev=49338b18fdb82dedb2a813664e2e565ca73e2047#49338b18)`, intermediate artifacts can be found at `/var/folders/nc/yfj0pylx4vzdr3s_66r129s00000gn/T/cargo-installci3owm`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  rustc 1.86.0 is not supported by the following package:
    [email protected] requires rustc 1.88
  Either upgrade rustc or select compatible dependency versions with
  `cargo update <name>@<current-ver> --precise <compatible-ver>`
  where `<compatible-ver>` is the latest version supporting rustc 1.86.0
make: *** [install-cross] Error 101

@vdice vdice force-pushed the chore/bump-rust-version-to-1.88 branch 2 times, most recently from 9e350d1 to fd3bcf3 Compare October 27, 2025 18:43
@vdice vdice force-pushed the chore/bump-rust-version-to-1.88 branch from fd3bcf3 to 1b660f7 Compare October 27, 2025 18:44
@vdice vdice changed the title chore(rust-toolchain): bump rust to 1.88.0 chore(rust-toolchain): bump rust to 1.88.0, address fmt/clippy errs Oct 27, 2025
@vdice vdice requested a review from kate-goldenring October 27, 2025 20:41
kate-goldenring
kate-goldenring approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping and cleaning this!

@vdice vdice merged commit 601ee16 into spinframework:main Oct 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@Mossaka Mossaka Awaiting requested review from Mossaka Mossaka is a code owner

@jsturtevant jsturtevant Awaiting requested review from jsturtevant jsturtevant is a code owner

@radu-matei radu-matei Awaiting requested review from radu-matei radu-matei is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vdice @kate-goldenring