Skip to content

Commit 49877b2

Browse files
Do not configure containerdRuntimeOptions when using MicroK8s
- This is due to a bug where the MicroK8s containerd is passing an empty body for the shim configuration options causing runwasi to error Signed-off-by: Kate Goldenring <[email protected]>
1 parent 0b4a91c commit 49877b2

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

.github/workflows/helm-chart-smoketest.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,18 @@ jobs:
152152
153153
- name: apply Spin shim
154154
run: |
155+
shim_file=config/samples/test_shim_spin.yaml
156+
if [[ "${{ matrix.config.type }}" == "microk8s" ]]; then
157+
cp $shim_file config/samples/test_shim_spin_microk8s.yaml
158+
shim_file=config/samples/test_shim_spin_microk8s.yaml
159+
# update file to remove the 'containerdRuntimeOptions' field
160+
# as there is a known bug that MicroK8s containerd does not pass the options
161+
yq -i 'del(.spec.containerdRuntimeOptions)' $shim_file
162+
fi
155163
# Ensure shim binary is compatible with runner arch
156164
yq -i '.spec.fetchStrategy.anonHttp.location = "https://github.com/spinframework/containerd-shim-spin/releases/download/${{ env.SHIM_SPIN_VERSION }}/containerd-shim-spin-v2-linux-x86_64.tar.gz"' \
157-
config/samples/test_shim_spin.yaml
158-
kubectl apply -f config/samples/test_shim_spin.yaml
165+
$shim_file
166+
kubectl apply -f $shim_file
159167
160168
- name: label nodes
161169
run: kubectl label node --all spin=true

0 commit comments

Comments
 (0)