fix: use ParseInt instead of Atoi to prevent potential integer overflow

ThorstenHans · ThorstenHans · commit 4e8fa1b08536 · 2025-01-08T10:58:21.000+01:00
Signed-off-by: Thorsten Hans &lt;thorsten.hans@fermyon.com&gt;
diff --git a/internal/controller/shim_controller.go b/internal/controller/shim_controller.go
@@ -462,7 +462,7 @@ func (sr *ShimReconciler) createJobManifest(shim *rcmv1.Shim, node *corev1.Node,
 	}
 	// set ttl for the installer job only if specified by the user
 	if ttlStr := os.Getenv("SHIM_NODE_INSTALLER_JOB_TTL"); ttlStr != "" {
-		if ttl, err := strconv.Atoi(ttlStr); err == nil && ttl > 0 {
+		if ttl, err := strconv.ParseInt(ttlStr, 10, 32); err == nil && ttl > 0 {
 			job.Spec.TTLSecondsAfterFinished = ptr(int32(ttl))
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ func (sr ShimReconciler) createJobManifest(shim rcmv1.Shim, node *corev1.Node,`
`462`	`462`	`}`
`463`	`463`	`// set ttl for the installer job only if specified by the user`
`464`	`464`	`if ttlStr := os.Getenv("SHIM_NODE_INSTALLER_JOB_TTL"); ttlStr != "" {`
`465`		`- if ttl, err := strconv.Atoi(ttlStr); err == nil && ttl > 0 {`
	`465`	`+ if ttl, err := strconv.ParseInt(ttlStr, 10, 32); err == nil && ttl > 0 {`
`466`	`466`	`job.Spec.TTLSecondsAfterFinished = ptr(int32(ttl))`
`467`	`467`	`}`
`468`	`468`	`}`