Skip to content

Commit 809bdd8

Browse files
authored
Merge pull request #5 from calebschoepp/new-domain
Add a skip about CRD domains
2 parents bddf16c + 4881d9e commit 809bdd8

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# SKIP 00X - CRD Domains
2+
3+
Summary: We should pivot to using the _spinkube.dev_ domain for all CRDs.
4+
5+
Owner: Caleb Schoepp <[email protected]>
6+
7+
Impacted Projects:
8+
9+
- [x] spin-operator
10+
- [ ] `spin kube` plugin
11+
- [x] runtime-class-manager
12+
- [ ] containerd-shim-spin
13+
- [ ] Governance
14+
- [ ] Creates a new project
15+
16+
Created: 11/07/2024
17+
18+
Updated: n/a
19+
20+
## Background
21+
22+
Kubernetes resources are identified by a unique [group, version, and kind](https://book.kubebuilder.io/cronjob-tutorial/gvks). Furthermore, the resource must be namespaced under a valid domain name. Currently the Spin Operator project has two custom resource definitions (CRDs): `SpinApp` and `SpinAppExecutor`. These CRDs use the domain _spinoperator.dev_.
23+
24+
## Proposal
25+
26+
I am proposing that we migrate from using _spinoperator.dev_ to _spinkube.dev_ as the domain for the Spin Operator CRDs. I also propose that going forward any new CRDs created by the Spin Operator project or any other SpinKube project use the _spinkube.dev_ domain.
27+
28+
The benefit of this change include:
29+
30+
- Consistency: All SpinKube projects will use the same domain for their CRDs.
31+
- Branding: The _spinkube.dev_ domain is more descriptive of the overall project than _spinoperator.dev_.
32+
- Future Proofing: The _spinkube.dev_ domain is more generic and allows for more flexibility in the future should anything about the Spin Operator change.
33+
34+
Changing the domain of a CRD is a breaking change and will require a full upgrade process which involves uninstalling the old CRDs and reinstalling the new CRDs. This is suboptimal, but is only reasonably achievable early in the lifetime of project like we are right now. Breaking changes like this only get harder the longer we wait.
35+
36+
## Alternatives Considered
37+
38+
### Sticking with _spinoperator.dev_
39+
40+
Alternatively, we could stick with the status quo if we don't think the breaking change is worth it.

0 commit comments

Comments
 (0)