Skip to content

Conversation

@mikkelhegn
Copy link
Contributor

A quick fix to add a bunch of derives to the Rust bindings. More work to expose as a flag to the CLI.

Also work to do to add wit-bindgen as a dependency if not there already.

@mikkelhegn
Copy link
Contributor Author

@karthik2804
Copy link
Collaborator

I assume the Todos will be handled in a separate PR? or is that still a WIP?

@mikkelhegn
Copy link
Contributor Author

Hmm - maybe talk about what to do and get it in to this PR would be an option? I'd like to close the loop on adding wit-bindgen. Maybe it's just an output to the console Make sure to add wit-bindgen to your project.?

@karthik2804
Copy link
Collaborator

I think just having an output to the console would be fine for now, because we have to otherwise end up parsing where the cargo.toml for that project is and things of that nature.

@mikkelhegn mikkelhegn marked this pull request as ready for review October 30, 2024 10:29
@mikkelhegn
Copy link
Contributor Author

Feel free to take it as-is.

@mikkelhegn
Copy link
Contributor Author

@karthik2804 I don't have merge rights, so it's up to you :-)

@karthik2804 karthik2804 merged commit 5afb01a into spinframework:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants