fix broken links script

+ exclude hashi and npm package links (429, 403)
+ fix issue with arg ordering
+ ensure temp files are being created and stale broken
lists are not printed

Signed-off-by: Michelle Dhanani <[email protected]>

Author: michelleN

.build/check-broken-links.sh

@@ -67,27 +67,35 @@ echo "starting link checker"
 ## Run the broken link checker
 report="$(mktemp)"
 blc_error=false
-blc --recursive http://127.0.0.1:3000                                                                                                                                                       \
-                                                                                                                                                                                            \
-    `## returns 403`                                                                                                                                                                        \
+if ! blc -rv                                                                                                                                                                                   \
+    `## returns 403`\
     --exclude 'https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits'                                                                            \
     --exclude 'https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account'                                                    \
     --exclude 'https://docs.github.com/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/remembering-your-github-username-or-email'    \
     --exclude 'https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification'                                                        \
     --exclude 'https://twitter.com/spinframework'                                                                                                                                           \
     --exclude 'https://linux.die.net/man/1/which'                                                                                                                                           \
-                                                                                                                                                                                            \
-    `## false positives`                                                                                                                                                                    \
+    --exclude 'npmjs.com/package/'                                                                                                                                           \
+    `## returns 429`\
+    --exclude 'developer.hashicorp.com'                                                                                                                                          \
+    `## false positives`\
     --exclude 'https://www.gnu.org/software/coreutils/'                                                                                                                                     \
     --exclude 'https://crates.io/'                                                                                                                                                          \
     --exclude 'https://crates.io/crates/bytes'                                                                                                                                              \
     --exclude 'https://crates.io/crates/http'                                                                                                                                               \
     --exclude 'https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one'                                                                                              \
     --exclude 'http://localhost:16686/'                                                                                                                                                     \
-    --exclude 'http://localhost:5050/explore' | tee "${report}" || blc_error=true
+    --exclude 'http://localhost:5050/explore'                                                                                                                                                     \
+    http://127.0.0.1:3000/v3/javascript-components \
+    | tee "${report}"
+then 
+    blc_error=true
+fi
 
-cat "${report}" | grep "├─BROKEN─" > broken_links || true
+broken_links="$(mktemp)"
+grep "├─BROKEN─" "$report" > broken_links || true
 
+final_broken="$(mktemp)"
 if [ -s broken_links ]; then
   echo "Some links are broken, retrying to check for transient errors"
   while read -r line; do

content/v1/python-components.md

@@ -240,7 +240,7 @@ Here is an animal fact: {"timestamp":1684299253331,"fact":"Reindeer grow new ant
 
 ## An Outbound Redis Example
 
-In this final example, we talk to an existing Redis instance. You can find the official [instructions on how to install Redis here](https://redis.io/docs/getting-started/installation/). We also gave a quick run-through on setting up Redis with Spin in our previous article called [Persistent Storage in Webassembly Applications](https://www.fermyon.com/blog/persistent-storage-in-webassembly-applications), so please take a look at that blog if you need a hand.
+In this final example, we talk to an existing Redis instance. You can find the official [instructions on how to install Redis here](https://redis.io/docs/latest/operate/oss_and_stack/install/install-stack/). We also gave a quick run-through on setting up Redis with Spin in our previous article called [Persistent Storage in Webassembly Applications](https://www.fermyon.com/blog/persistent-storage-in-webassembly-applications), so please take a look at that blog if you need a hand.
 
 ### Configuration
 

content/v2/python-components.md

@@ -411,7 +411,7 @@ Here is an animal fact: {"timestamp":1713156765221,"fact":"Bats are the only mam
 
 ## An Outbound Redis Example
 
-In this final example, we talk to an existing Redis instance. You can find the official [instructions on how to install Redis here](https://redis.io/docs/getting-started/installation/). We also gave a quick run-through on setting up Redis with Spin in our previous article called [Persistent Storage in Webassembly Applications](https://www.fermyon.com/blog/persistent-storage-in-webassembly-applications), so please take a look at that blog if you need a hand.
+In this final example, we talk to an existing Redis instance. You can find the official [instructions on how to install Redis here](https://redis.io/docs/latest/operate/oss_and_stack/install/install-stack/). We also gave a quick run-through on setting up Redis with Spin in our previous article called [Persistent Storage in Webassembly Applications](https://www.fermyon.com/blog/persistent-storage-in-webassembly-applications), so please take a look at that blog if you need a hand.
 
 ### Configuring Outbound Redis
 

content/v3/python-components.md

@@ -390,7 +390,7 @@ Here is an animal fact: {"timestamp":1713156765221,"fact":"Bats are the only mam
 
 ## An Outbound Redis Example
 
-In this final example, we talk to an existing Redis instance. You can find the official [instructions on how to install Redis here](https://redis.io/docs/getting-started/installation/). We also gave a quick run-through on setting up Redis with Spin in our previous article called [Persistent Storage in Webassembly Applications](https://www.fermyon.com/blog/persistent-storage-in-webassembly-applications), so please take a look at that blog if you need a hand.
+In this final example, we talk to an existing Redis instance. You can find the official [instructions on how to install Redis here](https://redis.io/docs/latest/operate/oss_and_stack/install/install-stack/). We also gave a quick run-through on setting up Redis with Spin in our previous article called [Persistent Storage in Webassembly Applications](https://www.fermyon.com/blog/persistent-storage-in-webassembly-applications), so please take a look at that blog if you need a hand.
 
 ### Configuring Outbound Redis