feat(mysql): implementing mysql in wasip2 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteurer
force-pushed
the
wasip2-mysql
branch
2 times, most recently
from
ce5d716 to
cd669eb
Compare
asteurer
changed the title
Author
|
I decided to just leave out the |
Contributor
|
Is it possible it's an interface version issue? Should it be Comparison: MySQL (error) vs MQTT (works I believe): extra v2.0.0 in import path: 
|
asteurer
force-pushed
the
wasip2-mysql
branch
2 times, most recently
from
5263d31 to
d3176ee
Compare
Author
|
@itowlson That did the trick! Thank you. This is ready for review. Please note that the example has been updated to include use of the |
adamreese
reviewed
Aug 27, 2025
Contributor
adamreese
left a comment
adamreese
left a comment
There was a problem hiding this comment.
Looking great! Can you add a package doc string like you did for redis?
Signed-off-by: Andrew Steurer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost finished; however, I could use some help figuring out how to implement the
driver.NamedValueCheckermethod on thestmtstruct. The comments on the interface indicate that it's supposed to help the driver handle types beyond the defaultValuetypes; however, I'm not clear on which additional types need to be converted?closes #30