Skip to content

Commit 64bde83

Browse files
committed
address review comments
Signed-off-by: karthik2804 <[email protected]>
1 parent 0cf1cc2 commit 64bde83

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed
Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
import { ResponseBuilder, Router } from "@fermyon/spin-sdk";
22

33
let router = Router();
4-
router.get("*", (_, req, res) => { handleDefaultRoute(req, res) })
5-
router.all("*", (_, req, res) => { notFound(req, res) })
4+
// Modify this route or add additional ones to implement the component's API:
5+
router.get("/hello/:name", (metadata, req, res) => { handleHelloRoute(req, res, metadata.params.name) });
6+
// Default route that will be called for any routes not handled above:
7+
router.all("*", (_, req, res) => { notFound(req, res) });
68

7-
async function handleDefaultRoute(req, res) {
8-
res.send("hello universe");
9+
async function handleHelloRoute(req, res, name) {
10+
res.send(`hello ${name}`);
911
}
10-
1112
async function notFound(req, res) {
1213
res.status(404);
1314
res.send("not found");
1415
}
1516

1617
export async function handler(req, res) {
1718
await router.handleRequest(req, res);
18-
}
19+
}
Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
import { ResponseBuilder, Router } from "@fermyon/spin-sdk";
22

33
let router = Router();
4-
router.get("*", (_, req, res) => { handleDefaultRoute(req, res) })
5-
router.all("*", (_, req, res) => { notFound(req, res) })
4+
// Modify this route or add additional ones to implement the component's API:
5+
router.get("/hello/:name", (metadata, req, res) => { handleHelloRoute(req, res, metadata.params.name) });
6+
// Default route that will be called for any routes not handled above:
7+
router.all("*", (_, req, res) => { notFound(req, res) });
68

7-
async function handleDefaultRoute(req: Request, res: ResponseBuilder) {
8-
res.send("hello universe");
9+
async function handleHelloRoute(req: Request, res: ResponseBuilder, name: string) {
10+
res.send(`hello ${name}`);
911
}
10-
1112
async function notFound(req: Request, res: ResponseBuilder) {
1213
res.status(404);
1314
res.send("not found");
1415
}
1516

1617
export async function handler(req: Request, res: ResponseBuilder) {
1718
await router.handleRequest(req, res);
18-
}
19+
}

0 commit comments

Comments
 (0)