Skip to content

Commit d0c0794

Browse files
authored
Merge pull request #89 from karthik2804/fix/resp_headers_ts
make headers optional for http response
2 parents a0714c4 + ec8b93b commit d0c0794

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

crates/spin-js-engine/src/js_sdk/modules/spinSdk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ interface HttpRequest extends BaseHttpRequest {
1919

2020
interface HttpResponse {
2121
status: number
22-
headers: Record<string, string>
22+
headers?: Record<string, string>
2323
body?: ArrayBuffer
2424
}
2525

@@ -74,7 +74,7 @@ function fetch(uri: string, options?: FetchOptions) {
7474
return Promise.resolve({
7575
status,
7676
headers: {
77-
entries: () => Object.entries(headers)
77+
entries: () => Object.entries(headers || {})
7878
},
7979
arrayBuffer: () => Promise.resolve(body),
8080
ok: (status > 199 && status < 300),

types/lib/modules/spinSdk.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ interface HttpRequest extends BaseHttpRequest {
1313
}
1414
interface HttpResponse {
1515
status: number;
16-
headers: Record<string, string>;
16+
headers?: Record<string, string>;
1717
body?: ArrayBuffer;
1818
}
1919
declare type HandleRequest = (request: HttpRequest) => Promise<HttpResponse>;

0 commit comments

Comments
 (0)