Skip to content

Commit 43dbb39

Browse files
Add TODO to add component filtering support to Spintainer executor
Signed-off-by: Kate Goldenring <[email protected]>
1 parent d4fa84d commit 43dbb39

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

internal/controller/spinapp_controller.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,8 @@ func constructDeployment(ctx context.Context, app *spinv1alpha1.SpinApp, config
464464
container = corev1.Container{
465465
Name: app.Name,
466466
Image: *config.SpinImage,
467-
Args: []string{"up", "--listen", fmt.Sprintf("0.0.0.0:%d", spinapp.DefaultHTTPPort), "-f", app.Spec.Image, "--runtime-config-file", "/runtime-config.toml"},
467+
// TODO: add support for --component-id flags to set components to be retained once spintainer supports Spin v3.0
468+
Args: []string{"up", "--listen", fmt.Sprintf("0.0.0.0:%d", spinapp.DefaultHTTPPort), "-f", app.Spec.Image, "--runtime-config-file", "/runtime-config.toml"},
468469
Ports: []corev1.ContainerPort{{
469470
Name: spinapp.HTTPPortName,
470471
ContainerPort: spinapp.DefaultHTTPPort,

0 commit comments

Comments
 (0)