feat: add ServiceAccountName field to SpinApp #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
changed the title
Mossaka
requested review from
bacongobbler,
endocrimes and
michelleN
as code owners
endocrimes
reviewed
Mar 6, 2025
endocrimes
approved these changes
Mar 6, 2025
This adds a new 'workloadIdentity' field to the SpinApp CRD and the controller will detect this field to determine whether or not to apply provider specific labels to enable cloud workload identity. See SKIP spinframework/skips#16 for more details Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
This change simplifies the SpinApp CRD by removing the complex WorkloadIdentity struct and replacing it with a simple ServiceAccountName field. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new 'ServiceAccountName' field to the SpinApp CRD and the controller will detect this field to determine whether or not to apply ServiceAccountName to the pod.
See SKIP spinframework/skips#16 for more details