if not service account name is provided, it will omit

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>

Author: Mossaka

pkg/cmd/scaffold.go

@@ -341,7 +341,7 @@ func init() {
 	scaffoldCmd.Flags().StringVar(&scaffoldOpts.memoryLimit, "memory-limit", "", "The maximum amount of memory the application is allowed to use")
 	scaffoldCmd.Flags().StringVar(&scaffoldOpts.memoryRequest, "memory-request", "", "The amount of memory requested by the application. Used to determine which node the application will run on")
 	scaffoldCmd.Flags().BoolVar(&scaffoldOpts.azureWorkloadIdentity, "azure-identity", false, "Enable Azure Workload Identity for the application")
-	scaffoldCmd.Flags().StringVar(&scaffoldOpts.serviceAccountName, "service-account-name", "default", "The name of the service account to use for the application")
+	scaffoldCmd.Flags().StringVar(&scaffoldOpts.serviceAccountName, "service-account-name", "", "The name of the service account to use for the application")
 	scaffoldCmd.Flags().StringVarP(&scaffoldOpts.from, "from", "f", "", "Reference in the registry of the application")
 	scaffoldCmd.Flags().StringVarP(&scaffoldOpts.output, "out", "o", "", "Path to file to write manifest yaml")
 	scaffoldCmd.Flags().StringVarP(&scaffoldOpts.configfile, "runtime-config-file", "c", "", "Path to runtime config file")

pkg/cmd/scaffold_test.go

@@ -75,6 +75,16 @@ func TestScaffoldOutput(t *testing.T) {
 			},
 			expected: "service_account_name.yml",
 		},
+		{
+			name: "service account name is not provided",
+			opts: ScaffoldOptions{
+				from:               "ghcr.io/foo/example-app:v0.1.0",
+				replicas:           2,
+				executor:           "containerd-shim-spin",
+				serviceAccountName: "",
+			},
+			expected: "no_service_account_name.yml",
+		},
 		{
 			name: "service account with HPA autoscaler",
 			opts: ScaffoldOptions{

pkg/cmd/testdata/no_service_account_name.yml

@@ -0,0 +1,8 @@
+apiVersion: core.spinkube.dev/v1alpha1
+kind: SpinApp
+metadata:
+  name: example-app
+spec:
+  image: "ghcr.io/foo/example-app:v0.1.0"
+  executor: containerd-shim-spin
+  replicas: 2