Merge pull request #118 from vdice/chore/bump-golangci-lint

chore(.github): bump golangci-lint-action to v8, version to v2.5.0, address lint errs

Author: vdice

.github/workflows/lint.yml

@@ -23,7 +23,7 @@ jobs:
           go-version: stable
           cache: false
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.64.6
+          version: v2.5.0
           args: --timeout 3m

pkg/cmd/get.go

@@ -32,8 +32,7 @@ var getCmd = &cobra.Command{
 			return err
 		}
 
-		printApps(os.Stdout, app)
-		return nil
+		return printApps(os.Stdout, app)
 	},
 }
 

pkg/cmd/list.go

@@ -17,9 +17,7 @@ var listCmd = &cobra.Command{
 			return err
 		}
 
-		printApps(os.Stdout, appsResp.Items...)
-
-		return nil
+		return printApps(os.Stdout, appsResp.Items...)
 	},
 }
 

pkg/cmd/output.go

@@ -8,7 +8,7 @@ import (
 	spinv1alpha1 "github.com/spinkube/spin-operator/api/v1alpha1"
 )
 
-func printApps(w io.Writer, apps ...spinv1alpha1.SpinApp) {
+func printApps(w io.Writer, apps ...spinv1alpha1.SpinApp) error {
 	table := uitable.New()
 	table.MaxColWidth = 50
 	table.AddRow("NAMESPACE", "NAME", "EXECUTOR", "READY")
@@ -17,5 +17,6 @@ func printApps(w io.Writer, apps ...spinv1alpha1.SpinApp) {
 		table.AddRow(app.Namespace, app.Name, app.Spec.Executor, fmt.Sprintf("%d/%d", app.Status.ReadyReplicas, app.Spec.Replicas))
 	}
 
-	fmt.Fprintln(w, table)
+	_, err := fmt.Fprintln(w, table)
+	return err
 }

pkg/cmd/scaffold.go

@@ -198,9 +198,9 @@ var scaffoldCmd = &cobra.Command{
 
 		}
 
-		fmt.Fprint(os.Stdout, string(content))
+		_, err = fmt.Fprint(os.Stdout, string(content))
 
-		return nil
+		return err
 	},
 }