factors: Fix clippy lints

Signed-off-by: Lann Martin <[email protected]>

Author: lann

crates/factor-key-value-azure/src/lib.rs

@@ -5,14 +5,15 @@ use spin_key_value_azure::{
 };
 
 /// A key-value store that uses Azure Cosmos as the backend.
+#[derive(Default)]
 pub struct AzureKeyValueStore {
     _priv: (),
 }
 
 impl AzureKeyValueStore {
     /// Creates a new `AzureKeyValueStore`.
     pub fn new() -> Self {
-        Self { _priv: () }
+        Self::default()
     }
 }
 

crates/factor-key-value-redis/src/lib.rs

@@ -3,14 +3,15 @@ use spin_factor_key_value::runtime_config::spin::MakeKeyValueStore;
 use spin_key_value_redis::KeyValueRedis;
 
 /// A key-value store that uses Redis as the backend.
+#[derive(Default)]
 pub struct RedisKeyValueStore {
     _priv: (),
 }
 
 impl RedisKeyValueStore {
     /// Creates a new `RedisKeyValueStore`.
     pub fn new() -> Self {
-        Self { _priv: () }
+        Self::default()
     }
 }
 

crates/factor-outbound-redis/src/lib.rs

@@ -8,13 +8,14 @@ use spin_factors::{
 };
 
 /// The [`Factor`] for `fermyon:spin/outbound-redis`.
+#[derive(Default)]
 pub struct OutboundRedisFactor {
     _priv: (),
 }
 
 impl OutboundRedisFactor {
     pub fn new() -> Self {
-        Self { _priv: () }
+        Self::default()
     }
 }
 

crates/factor-sqlite/src/host.rs

@@ -44,9 +44,10 @@ impl InstanceState {
     fn get_connection(
         &self,
         connection: Resource<v2::Connection>,
-    ) -> Result<&Box<dyn Connection>, v2::Error> {
+    ) -> Result<&dyn Connection, v2::Error> {
         self.connections
             .get(connection.rep())
+            .map(|conn| conn.as_ref())
             .ok_or(v2::Error::InvalidConnection)
     }
 }

crates/factor-sqlite/tests/factor_test.rs

@@ -104,7 +104,8 @@ impl FactorRuntimeConfigSource<SqliteFactor> for TomlRuntimeSource<'_> {
 
 impl RuntimeConfigSourceFinalizer for TomlRuntimeSource<'_> {
     fn finalize(&mut self) -> anyhow::Result<()> {
-        Ok(self.table.validate_all_keys_used().unwrap())
+        self.table.validate_all_keys_used()?;
+        Ok(())
     }
 }
 

crates/factor-variables/src/spin_cli/azure_key_vault.rs

@@ -90,6 +90,7 @@ pub enum AzureKeyVaultAuthOptions {
     ///
     /// Common across each:
     /// - `AZURE_AUTHORITY_HOST`: (optional) the host for the identity provider. For example, for Azure public cloud the host defaults to "https://login.microsoftonline.com".
+    ///
     /// See also: https://github.com/Azure/azure-sdk-for-rust/blob/main/sdk/identity/README.md
     Environmental,
 }

crates/factor-variables/tests/factor_test.rs

@@ -31,7 +31,7 @@ async fn static_provider_works() -> anyhow::Result<()> {
         }))?;
 
     let mut state = env.build_instance_state().await?;
-    let val = state.variables.get("baz".try_into().unwrap()).await?;
+    let val = state.variables.get("baz".into()).await?;
     assert_eq!(val, "<bar>");
     Ok(())
 }

crates/runtime-config/src/lib.rs

@@ -187,11 +187,7 @@ impl FactorRuntimeConfigSource<OutboundMysqlFactor> for TomlRuntimeConfigSource<
 
 impl FactorRuntimeConfigSource<LlmFactor> for TomlRuntimeConfigSource<'_> {
     fn get_runtime_config(&mut self) -> anyhow::Result<Option<spin_factor_llm::RuntimeConfig>> {
-        Ok(llm::runtime_config_from_toml(
-            self.table.as_ref(),
-            self.state_dir.clone(),
-            self.use_gpu,
-        )?)
+        llm::runtime_config_from_toml(self.table.as_ref(), self.state_dir.clone(), self.use_gpu)
     }
 }