Skip to content

Commit 145e72b

Browse files
committed
Move instruments up a level in factor-variables
Signed-off-by: Caleb Schoepp <[email protected]>
1 parent ba32722 commit 145e72b

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

crates/factor-variables/src/host.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
use spin_factors::anyhow;
22
use spin_world::{async_trait, v1, v2::variables};
3+
use tracing::{instrument, Level};
34

45
use crate::InstanceState;
56

67
#[async_trait]
78
impl variables::Host for InstanceState {
9+
#[instrument(name = "spin_variables.get", skip(self), err(level = Level::INFO), fields(otel.kind = "client"))]
810
async fn get(&mut self, key: String) -> Result<String, variables::Error> {
911
let key = spin_expressions::Key::new(&key).map_err(expressions_to_variables_err)?;
1012
self.expression_resolver

crates/factor-variables/src/spin_cli/azure_key_vault.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ impl AzureKeyVaultProvider {
134134

135135
#[async_trait]
136136
impl Provider for AzureKeyVaultProvider {
137-
#[instrument(name = "spin_variables.get_from_azure_key_vault", skip(self), err(level = Level::INFO), fields(otel.kind = "client"))]
137+
#[instrument(name = "spin_variables.get_from_azure_key_vault", level = Level::DEBUG, skip(self), err(level = Level::INFO), fields(otel.kind = "client"))]
138138
async fn get(&self, key: &Key) -> anyhow::Result<Option<String>> {
139139
let secret = self
140140
.secret_client

crates/factor-variables/src/spin_cli/env.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ fn load_dotenv(dotenv_path: &Path) -> anyhow::Result<HashMap<String, String>> {
128128

129129
#[async_trait]
130130
impl Provider for EnvVariablesProvider {
131-
#[instrument(name = "spin_variables.get_from_env", skip(self), err(level = Level::INFO))]
131+
#[instrument(name = "spin_variables.get_from_env", level = Level::DEBUG, skip(self), err(level = Level::INFO))]
132132
async fn get(&self, key: &Key) -> anyhow::Result<Option<String>> {
133133
tokio::task::block_in_place(|| self.get_sync(key))
134134
}

crates/factor-variables/src/spin_cli/vault.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ pub struct VaultVariablesProvider {
2727

2828
#[async_trait]
2929
impl Provider for VaultVariablesProvider {
30-
#[instrument(name = "spin_variables.get_from_vault", skip(self), err(level = Level::INFO), fields(otel.kind = "client"))]
30+
#[instrument(name = "spin_variables.get_from_vault", level = Level::DEBUG, skip(self), err(level = Level::INFO), fields(otel.kind = "client"))]
3131
async fn get(&self, key: &Key) -> anyhow::Result<Option<String>> {
3232
let client = VaultClient::new(
3333
VaultClientSettingsBuilder::default()

0 commit comments

Comments
 (0)