Fix bad behaviour on "invalid Wasm" case (used in tests)

Signed-off-by: itowlson <[email protected]>

Author: itowlson

crates/build/src/deployment.rs

@@ -14,4 +14,10 @@ impl DeploymentTargets {
     pub fn iter(&self) -> impl Iterator<Item = &str> {
         self.target_environments.iter().map(|s| s.as_str())
     }
+
+    pub fn is_empty(&self) -> bool {
+        // TODO: it would be nice to let "no-op" behaviour fall out organically,
+        // but currently we do some stuff eagerly, so...
+        self.target_environments.is_empty()
+    }
 }

crates/build/src/lib.rs

@@ -37,15 +37,17 @@ pub async fn build(manifest_file: &Path, component_ids: &[String]) -> Result<()>
     build_result?;
 
     if let Ok(manifest) = &manifest {
-        let resolution_context = spin_environments::ResolutionContext {
-            base_dir: manifest_file.parent().unwrap().to_owned(),
-        };
-        spin_environments::validate_application_against_environment_ids(
-            deployment_targets.iter(),
-            manifest,
-            &resolution_context,
-        )
-        .await?;
+        if !deployment_targets.is_empty() {
+            let resolution_context = spin_environments::ResolutionContext {
+                base_dir: manifest_file.parent().unwrap().to_owned(),
+            };
+            spin_environments::validate_application_against_environment_ids(
+                deployment_targets.iter(),
+                manifest,
+                &resolution_context,
+            )
+            .await?;
+        }
     }
 
     Ok(())