Merge pull request #1908 from fermyon/give-permissions

CI: give permissions to lint job to cancel entire workflow

Author: rylev

.github/workflows/build.yml

@@ -25,6 +25,9 @@ jobs:
   lint-rust:
     name: Lint Rust
     runs-on: "ubuntu-latest"
+    permissions:
+      ## Allow this job to potentially cancel the running workflow (on failure)
+      actions: write
     steps:
       - uses: actions/checkout@v3
 
@@ -36,9 +39,7 @@ jobs:
           rust-cache: true
 
       - name: Run lints
-        run: |
-            BUILD_SPIN_EXAMPLES=0 make lint
-            git diff --name-status --exit-code . || (echo "Git working tree dirtied by lints. Run 'make update-cargo-locks' and check in changes" && exit 1)
+        run: BUILD_SPIN_EXAMPLES=0 make lint
 
       - name: Cancel everything if linting fails
         if: failure()

Makefile

@@ -60,8 +60,10 @@ lint: lint-rust-examples-and-testcases
 .PHONY: lint-rust-examples-and-testcases
 lint-rust-examples-and-testcases:
 	for manifest_path in $$(find examples tests/testcases -name Cargo.toml); do \
-		cargo clippy --manifest-path "$${manifest_path}" -- -D warnings \
+		echo "Linting $${manifest_path}" \
+		&& cargo clippy --manifest-path "$${manifest_path}" -- -D warnings \
 		&& cargo fmt --manifest-path "$${manifest_path}" -- --check \
+		&& (git diff --name-status --exit-code . || (echo "Git working tree dirtied by lints. Run 'make update-cargo-locks' and check in changes" && false)) \
 		|| exit 1 ; \
 	done