Merge pull request #3286 from itowlson/thats-it-private-ips-test-you-have-crossed-me-once-too-often

lann · web-flow · commit 64bf4e437d4a · 2025-10-03T08:27:41.000-04:00
Ignore flaky test on Mac
diff --git a/crates/factor-outbound-http/tests/factor_test.rs b/crates/factor-outbound-http/tests/factor_test.rs
@@ -67,6 +67,7 @@ async fn disallowed_host_fails() -> anyhow::Result<()> {
     Ok(())
 }
 
+#[cfg_attr(target_os = "macos", ignore)]
 #[tokio::test(flavor = "multi_thread")]
 async fn disallowed_private_ips_fails() -> anyhow::Result<()> {
     async fn run_test(allow_private_ips: bool) -> anyhow::Result<()> {

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ async fn disallowed_host_fails() -> anyhow::Result<()> {`
`67`	`67`	`Ok(())`
`68`	`68`	`}`
`69`	`69`
	`70`	`+#[cfg_attr(target_os = "macos", ignore)]`
`70`	`71`	`#[tokio::test(flavor = "multi_thread")]`
`71`	`72`	`async fn disallowed_private_ips_fails() -> anyhow::Result<()> {`
`72`	`73`	`async fn run_test(allow_private_ips: bool) -> anyhow::Result<()> {`