Merge pull request #3147 from fibonacci1729/warn-on-mem-exceeded

Warn when max memory is exceeded

Author: fibonacci1729

Cargo.toml

@@ -164,7 +164,7 @@ tokio = "1"
 tokio-rustls = { version = "0.26", default-features = false, features = ["logging", "tls12"] }
 toml = "0.8"
 toml_edit = "0.22"
-tracing = { version = "0.1", features = ["log"] }
+tracing = { version = "0.1.41", features = ["log"] }
 url = "2"
 walkdir = "2"
 wasm-encoder = "0.230"

crates/core/src/limits.rs

@@ -17,7 +17,7 @@ impl ResourceLimiterAsync for StoreLimitsAsync {
         &mut self,
         current: usize,
         desired: usize,
-        _maximum: Option<usize>,
+        maximum: Option<usize>,
     ) -> Result<bool> {
         let can_grow = if let Some(limit) = self.max_memory_size {
             desired <= limit
@@ -27,6 +27,15 @@ impl ResourceLimiterAsync for StoreLimitsAsync {
         if can_grow {
             self.memory_consumed =
                 (self.memory_consumed as i64 + (desired as i64 - current as i64)) as u64;
+        } else {
+            tracing::warn!(
+                "error.type" = "memory_limit_exceeded",
+                current,
+                desired,
+                maximum,
+                max_memory_size = self.max_memory_size,
+                "instance memory limit exceeded",
+            );
         }
         Ok(can_grow)
     }