Skip to content

Commit 703252f

Browse files
authored
Merge pull request #3168 from spinframework/allowed-hosts-refactoring
outbound-networking refactoring
2 parents baa07a3 + 940574c commit 703252f

File tree

2 files changed

+110
-68
lines changed

2 files changed

+110
-68
lines changed

crates/loader/src/local.rs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ use spin_locked_app::{
1212
values::{ValuesMap, ValuesMapBuilder},
1313
};
1414
use spin_manifest::schema::v2::{self, AppManifest, KebabId, WasiFilesMount};
15-
use spin_outbound_networking_config::allowed_hosts::{
16-
AllowedHostsConfig, SERVICE_CHAINING_DOMAIN_SUFFIX,
17-
};
15+
use spin_outbound_networking_config::allowed_hosts::{AllowedHostConfig, AllowedHostsConfig};
1816
use spin_serde::DependencyName;
1917
use std::collections::BTreeMap;
2018
use tokio::{io::AsyncWriteExt, sync::Semaphore};
@@ -841,19 +839,7 @@ fn requires_service_chaining(component: &spin_manifest::schema::v2::Component) -
841839
}
842840

843841
fn is_chaining_host(pattern: &str) -> bool {
844-
use spin_outbound_networking_config::allowed_hosts::{AllowedHostConfig, HostConfig};
845-
846-
let Ok(allowed) = AllowedHostConfig::parse(pattern) else {
847-
return false;
848-
};
849-
850-
match allowed.host() {
851-
HostConfig::List(hosts) => hosts
852-
.iter()
853-
.any(|h| h.ends_with(SERVICE_CHAINING_DOMAIN_SUFFIX)),
854-
HostConfig::AnySubdomain(domain) => domain == SERVICE_CHAINING_DOMAIN_SUFFIX,
855-
_ => false,
856-
}
842+
AllowedHostConfig::parse(pattern).is_ok_and(|config| config.is_for_service_chaining())
857843
}
858844

859845
const SLOTH_WARNING_DELAY_MILLIS: u64 = 1250;

0 commit comments

Comments
 (0)