remove redundant return value

Signed-off-by: Aminu 'Seun Joshua <[email protected]>

Author: seun-ja

crates/runtime-config/src/variables.rs

@@ -97,21 +97,17 @@ impl VariableProviderConfiguration {
 }
 
 pub trait VariableSourcer {
-    fn variable_env_checker(
-        &self,
-        key: String,
-        val: Variable,
-    ) -> anyhow::Result<(String, Variable)>;
+    fn variable_env_checker(&self, key: String, val: Variable) -> anyhow::Result<()>;
 
     fn check(
         &self,
         key: String,
         mut val: Variable,
         dotenv_path: Option<PathBuf>,
         prefix: Option<String>,
-    ) -> anyhow::Result<(String, Variable)> {
+    ) -> anyhow::Result<()> {
         if val.default.is_some() {
-            return Ok((key, val));
+            return Ok(());
         }
 
         if let Some(path) = dotenv_path {
@@ -121,7 +117,7 @@ pub trait VariableSourcer {
         match std::env::var(env_key(prefix, &key)) {
             Ok(v) => {
                 val.default = Some(v);
-                Ok((key, val))
+                Ok(())
             }
             Err(_) => Err(anyhow::anyhow!(
                 "Variable data not provided for {}",

crates/trigger/src/cli/variables.rs

@@ -28,11 +28,7 @@ impl<F: RuntimeFactors, U> ExecutorHooks<F, U> for VariableSorterExecutorHooks {
 }
 
 impl VariableSourcer for VariableSorterExecutorHooks {
-    fn variable_env_checker(
-        &self,
-        key: String,
-        val: spin_app::Variable,
-    ) -> anyhow::Result<(String, spin_app::Variable)> {
+    fn variable_env_checker(&self, key: String, val: spin_app::Variable) -> anyhow::Result<()> {
         let configs = spin_variables::variable_provider_config_from_toml(&self.table)?;
 
         if let Some(config) = configs.into_iter().next() {