test refactoring

Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>

Author: seun-ja

crates/expressions/tests/validation_test.rs

@@ -46,7 +46,10 @@ impl ResolverTester {
 #[tokio::test(flavor = "multi_thread")]
 async fn if_single_static_provider_with_no_key_to_resolve_is_valid() -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -58,8 +61,11 @@ async fn if_single_static_provider_with_no_key_to_resolve_is_valid() -> anyhow::
 async fn if_single_static_provider_has_data_for_variable_key_to_resolve_it_succeeds(
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_variable("foo", None)
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_variable("database_host", None)
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -71,8 +77,11 @@ async fn if_single_static_provider_has_data_for_variable_key_to_resolve_it_succe
 async fn if_there_is_a_single_static_provider_and_it_does_not_contain_a_required_variable_then_validation_fails(
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_variable("bar", None)
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_variable("api_key", None)
         .make_resolver()?;
 
     assert!(resolver.ensure_required_variables_resolved().await.is_err());
@@ -85,7 +94,7 @@ async fn if_there_is_a_dynamic_provider_then_validation_succeeds_even_without_de
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
         .with_provider(DynamicProvider)
-        .with_variable("bar", None)
+        .with_variable("api_key", None)
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -98,8 +107,11 @@ async fn if_there_is_a_dynamic_provider_and_static_provider_but_the_variable_to_
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
         .with_provider(DynamicProvider)
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_variable("baz", None)
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_variable("api_key", None)
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -112,8 +124,11 @@ async fn if_there_is_a_dynamic_provider_and_a_static_provider_then_validation_su
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
         .with_provider(DynamicProvider)
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_variable("baz", Some("coo"))
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_variable("api_key", Some("super-secret-key"))
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -124,9 +139,15 @@ async fn if_there_is_a_dynamic_provider_and_a_static_provider_then_validation_su
 #[tokio::test(flavor = "multi_thread")]
 async fn if_there_are_two_static_providers_where_one_has_data_is_valid() -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_provider(StaticProvider::with_variable("baz", Some("hay")))
-        .with_variable("foo", None)
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_provider(StaticProvider::with_variable(
+            "api_key",
+            Some("super-secret-key"),
+        ))
+        .with_variable("database_host", None)
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -140,9 +161,15 @@ async fn if_there_are_two_static_providers_where_one_has_data_is_valid() -> anyh
 async fn if_there_are_two_static_providers_where_first_provider_does_not_have_data_while_second_provider_does(
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_provider(StaticProvider::with_variable("baz", Some("hay")))
-        .with_variable("baz", None)
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_provider(StaticProvider::with_variable(
+            "api_key",
+            Some("super-secret-key"),
+        ))
+        .with_variable("api_key", None)
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;
@@ -153,8 +180,14 @@ async fn if_there_are_two_static_providers_where_first_provider_does_not_have_da
 #[tokio::test(flavor = "multi_thread")]
 async fn if_there_is_two_static_providers_neither_having_data_is_invalid() -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_provider(StaticProvider::with_variable("foo", Some("bar")))
-        .with_provider(StaticProvider::with_variable("baz", Some("hay")))
+        .with_provider(StaticProvider::with_variable(
+            "database_host",
+            Some("localhost"),
+        ))
+        .with_provider(StaticProvider::with_variable(
+            "api_key",
+            Some("super-secret-key"),
+        ))
         .with_variable("hello", None)
         .make_resolver()?;
 
@@ -167,7 +200,7 @@ async fn if_there_is_two_static_providers_neither_having_data_is_invalid() -> an
 async fn no_provider_data_available_but_variable_default_value_needed_is_invalid(
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_variable("hello", None)
+        .with_variable("api_key", None)
         .make_resolver()?;
 
     assert!(resolver.ensure_required_variables_resolved().await.is_err());
@@ -179,7 +212,7 @@ async fn no_provider_data_available_but_variable_default_value_needed_is_invalid
 async fn no_provider_data_available_but_variable_has_default_value_needed_is_valid(
 ) -> anyhow::Result<()> {
     let resolver = ResolverTester::new()
-        .with_variable("hello", Some("World"))
+        .with_variable("api_key", Some("super-secret-key"))
         .make_resolver()?;
 
     resolver.ensure_required_variables_resolved().await?;