Tests and contexting some file-not-found errors

Signed-off-by: itowlson <[email protected]>

Author: itowlson

crates/build/src/lib.rs

@@ -246,4 +246,56 @@ mod tests {
             .await
             .unwrap();
     }
+
+    #[tokio::test]
+    async fn succeeds_if_target_env_matches() {
+        let manifest_path = test_data_root().join("good_target_env.toml");
+        build(&manifest_path, &[], TargetChecking::Check, None)
+            .await
+            .unwrap();
+    }
+
+    #[tokio::test]
+    async fn fails_if_target_env_does_not_match() {
+        let manifest_path = test_data_root().join("bad_target_env.toml");
+        let err = build(&manifest_path, &[], TargetChecking::Check, None)
+            .await
+            .expect_err("should have failed")
+            .to_string();
+
+        // build prints validation errors rather than returning them to top level
+        // (because there could be multiple errors) - see has_meaningful_error_if_target_env_does_not_match
+        assert!(
+            err.contains("one or more was incompatible with one or more of the deployment targets")
+        );
+    }
+
+    #[tokio::test]
+    async fn has_meaningful_error_if_target_env_does_not_match() {
+        let manifest_file = test_data_root().join("bad_target_env.toml");
+        let manifest = spin_manifest::manifest_from_file(&manifest_file).unwrap();
+        let application = spin_environments::ApplicationToValidate::new(
+            manifest.clone(),
+            manifest_file.parent().unwrap(),
+        )
+        .await
+        .context("unable to load application for checking against deployment targets")
+        .unwrap();
+
+        let target_validation = spin_environments::validate_application_against_environment_ids(
+            &application,
+            &manifest.application.targets,
+            None,
+            manifest_file.parent().unwrap(),
+        )
+        .await
+        .context("unable to check if the application is compatible with deployment targets")
+        .unwrap();
+
+        assert_eq!(1, target_validation.errors().len());
+
+        let err = target_validation.errors()[0].to_string();
+
+        assert!(err.contains("world wasi:cli/[email protected] does not provide an import named"));
+    }
 }

crates/build/tests/bad_target_env.toml

@@ -0,0 +1,8 @@
+spin_manifest_version = 2
+
+[application]
+name = "bad"
+targets = [{ path = "env/wasi-minimal.toml" }]
+
+[[trigger.command]]
+component = { source = "test-components/test-command.wasm" }

crates/build/tests/env/wasi-all.toml

@@ -0,0 +1,2 @@
+[triggers]
+command = { worlds = [{ path = "../wit/cmd-full", world = "wasi:cli/[email protected]"}] }

crates/build/tests/env/wasi-minimal.toml

@@ -0,0 +1,2 @@
+[triggers]
+command = { worlds = [{ path = "../wit/cmd-minimal", world = "wasi:cli/[email protected]"}] }

crates/build/tests/good_target_env.toml

@@ -0,0 +1,8 @@
+spin_manifest_version = 2
+
+[application]
+name = "good"
+targets = [{ path = "env/wasi-all.toml" }]
+
+[[trigger.command]]
+component = { source = "test-components/test-command.wasm" }

crates/build/tests/test-components/README.md

@@ -0,0 +1,10 @@
+# Recreating the test components
+
+```
+cd source/test-command
+cargo build --release --target wasm32-wasip1
+```
+
+then copy from `target/wasm32-wasip1/release/` to this directory.
+
+**IMPORTANT:** Do not use the `wasm32-wasip2` target. It generates to the 0.2.x world (0.2.3 at time of writing), and Component Model tooling does not yet accept that as compatible with the 0.2.0 world.

crates/build/tests/test-components/source/test-command/Cargo.toml

@@ -0,0 +1,8 @@
+[package]
+name = "test-command"
+version = "0.1.0"
+edition = "2024"
+
+[dependencies]
+
+[workspace]

crates/build/tests/test-components/source/test-command/src/main.rs

@@ -0,0 +1,3 @@
+fn main() {
+    println!("Hello, world!");
+}

crates/build/tests/test-components/test-command.wasm

@@ -0,0 +1,7 @@
+package wasi:cli@0.2.0;
+
+world command {
+  include imports;
+
+  export run;
+}